feat(deploy): support extra compose override files via BUZZ_COMPOSE_EXTRA_FILES - #4152
Open
kajukabla wants to merge 1 commit into
Open
feat(deploy): support extra compose override files via BUZZ_COMPOSE_EXTRA_FILES#4152kajukabla wants to merge 1 commit into
kajukabla wants to merge 1 commit into
Conversation
…XTRA_FILES deploy/compose/run.sh passes explicit -f flags to docker compose, which disables automatic compose.override.yml loading, so operators had no way to layer site-local overrides (resource limits, labels, host tweaks) without editing tracked files or re-running docker update after every upgrade. Add BUZZ_COMPOSE_EXTRA_FILES: a colon- or space-separated list of compose files appended as additional -f flags after the built-in ones, so operator values win the Compose merge. Missing entries fail fast with a clear error. Documented in ./run.sh help and the deploy README. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: kajukabla <106099463+kajukabla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy/compose/run.shassembles itsdocker composeinvocation from explicit-fflags (compose.ymlplus the conditional caddy/dev overlays). Passing any explicit-fdisables Compose's automaticcompose.override.ymlloading, so operators currently have no way to layer site-local overrides — acompose.override.ymlsitting in the directory is silently ignored.This adds a
BUZZ_COMPOSE_EXTRA_FILESenvironment switch: a colon- or space-separated list of compose files appended as additional-fflags after the built-in ones, so operator values win the Compose merge. Missing entries fail fast with a clear error instead of a mid-commanddocker composefailure.Real-world motivation: staging the relay on a shared ML box needed memory caps on the relay container, which today requires re-running
docker updateafter every./run.sh upgrade. With this change the cap lives in a small override file and survives upgrades:Changes
deploy/compose/run.sh— parseBUZZ_COMPOSE_EXTRA_FILES(colon- or space-separated), validate each path exists, append as-fflags after the built-in files; document the switch in./run.sh helpdeploy/compose/README.md— new "Site-local overrides" section with the resource-limit example and a note that explicit-fflags are whycompose.override.ymlis not auto-loadedTesting
bash -n run.shsyntax checkdockeronPATHasserting exact flags:-f compose.ymlunchanged-f compose.yml -f /tmp/x-limits.yml -f /tmp/x-labels.ymlBUZZ_COMPOSE_EXTRA_FILES entry not found: ...BUZZ_COMPOSE_TLS=true: extra file appended aftercompose.caddy.ymljust ci— all recipes pass exceptmobile-test, which fails on one pre-existing widget test (ChannelDetailPage keeps follow mode off while a tall newest message stays visible,mobile/test/features/channels/channel_detail_page_test.dart:1042). It fails identically on cleanmain(7e9b77f) and this PR touches onlydeploy/compose/, so it is unrelated.🤖 Generated with Claude Code