buzz-acp: add structured MCP server configuration - #4164
Open
wolfyy970 wants to merge 2 commits into
Open
Conversation
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
This was referenced Aug 1, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9e32d5848
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a versioned JSON config for defining multiple named MCP servers in
buzz-acp.The new
--mcp-configandBUZZ_ACP_MCP_CONFIGinputs preserve each server's name, command, arguments, order, and environment without shell parsing. Invalid configuration fails before startup. The existingBUZZ_ACP_MCP_COMMANDpath is unchanged and remains first when both inputs are present.MCP environment values are redacted from Buzz wire logs and observer events. Serialized request payloads echoed by an adapter in errors or diagnostics are suppressed without changing the protocol value.
Desktop also reserves
BUZZ_ACP_MCP_CONFIGbecause it points to a code-execution surface.Fixes #4154.
Notes
Structured MCP servers receive only their declared environment in the ACP request. This is not process isolation: the adapter still inherits the harness environment and controls its MCP child processes.
The diagnostic redaction overlaps #3417.
Validation
cargo test -p buzz-acp --no-fail-fast(686 unit tests, 10 integration tests)cargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt --all -- --check./bin/just ci