Skip to content

fix(desktop): show shared invocable agents in mentions - #4242

Open
bluestonetrust wants to merge 4 commits into
block:mainfrom
bluestonetrust:fix/shared-agent-channel-mentions
Open

fix(desktop): show shared invocable agents in mentions#4242
bluestonetrust wants to merge 4 commits into
block:mainfrom
bluestonetrust:fix/shared-agent-channel-mentions

Conversation

@bluestonetrust

@bluestonetrust bluestonetrust commented Aug 2, 2026

Copy link
Copy Markdown

Summary

  • show relay-discovered agents in stream and forum mention autocomplete when the current user can invoke them through a shared channel or explicit allowlist
  • keep unrelated or unavailable agent identities hidden
  • preserve the existing managed-only rule in DMs and group DMs
  • fail closed to the managed-only picker while the channel type is unresolved
  • verify that selecting a shared agent emits the outbound Nostr p tag required to wake that agent

Root cause

The Desktop mention picker filtered every agent identity against the current user's managed-agent list. An agent owned by another user could therefore be callable in a shared stream but remain impossible to select, so the outgoing message never carried that agent's p tag.

User impact

Members of a normal shared channel can now discover and mention agents that explicitly permit them to invoke the agent. The ACP runtime remains authoritative for access enforcement, and the stricter DM/group-DM boundary is unchanged.

Validation

  • pnpm test — 3,906 passed
  • pnpm check — passed
  • pnpm build:e2e — passed
  • pnpm exec playwright test tests/e2e/mentions.spec.ts — 53 passed
  • independent security and correctness re-review — no blocking findings

Originating Buzz channel: 1e408238-c672-4d83-ab5c-25ff3f7401eb

Khanh Le added 4 commits August 2, 2026 13:37
Include relay agents that the current user can invoke through a shared channel or allowlist while continuing to hide unavailable agent identities. Keep duplicate agent entries coalesced and cover the picker and outbound mention flow with unit and browser tests.

Co-authored-by: Khanh Le <bluestonetrust04@gmail.com>
Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
Co-authored-by: Khanh Le <bluestonetrust04@gmail.com>
Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
Co-authored-by: Khanh Le <bluestonetrust04@gmail.com>
Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
Pass the known forum channel type only from forum-backed composers so other ForumComposer reuse stays fail closed. Strengthen the DM and unresolved-state browser controls and cover relay-only forum autocomplete.

Co-authored-by: Khanh Le <bluestonetrust04@gmail.com>
Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
@bluestonetrust
bluestonetrust marked this pull request as ready for review August 2, 2026 04:20
@bluestonetrust
bluestonetrust requested a review from a team as a code owner August 2, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant