fix(desktop): defer managed-agent pools by default - #4254
Open
kerpopule wants to merge 1 commit into
Open
Conversation
Manual starts and config-driven restarts now use the lazy ACP pool path already used by launch restore. New and legacy records without explicit parallelism default to one worker instead of ten.\n\nThis prevents a fleet of idle identities from eagerly reserving hundreds of ACP subprocesses. The behavior follows the earlier designs in block#2639 and block#2676, adapted to current main. Signed-off-by: Steve Darlow <kerpopule@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Confirmed on Buzz 0.5.3 with a real multi-agent Hermes setup: 33 running
buzz-acpparents each eagerly initialized 10hermes-acpchildren. That produced 331 Hermes ACP processes using 7,634.4 MiB RSS before Buzz itself, with load average 32.72. The fleet was mostly idle.Existing records with an explicit parallelism value are intentionally not rewritten. This changes safe defaults and prevents manual/config restarts from eagerly materializing every configured slot.
This adapts the designs from #2639 by @BrianSeong99 and #2676 by @Christian-Sidak onto current
main; both earlier PRs currently conflict.Verification
cargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --checkcd desktop/src-tauri && cargo test: 2,090 passed, 14 ignored; diagnostic integration tests 3 passedcd desktop/src-tauri && cargo clippy --all-targets -- -D warningsgit diff --checkFixes #2631.