fix(desktop): update vulnerable nostr relay pool - #4256
Open
BrianInAz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Brian Charbonneau <github@briancharbonneau.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nostr-relay-pool0.44.1 to 0.44.2, fixing RUSTSEC-2026-0224unmaintainedfindings to direct workspace dependenciesFixes #4251.
Reproduction
At upstream commit
28ae6cd2174309529305724e455c7ca082f6fe4b, the rootCargo.lockcontains the fixed 0.44.2 release, but the separately resolved desktop lockfile still contains 0.44.1:The existing root-only
cargo-deny checkdoes not inspect this independent lockfile.Solution
The desktop lockfile is pinned to 0.44.2, the first patched release. CI now runs a locked advisory scan for the supported Apple Silicon desktop target and excludes development-only dependencies. Vulnerabilities remain errors;
unmaintained = "workspace"prevents unrelated, no-fix transitive notices from blocking the target-specific scan while preserving direct-dependency enforcement.Validation
cargo-deny check— passedcargo-deny --locked --manifest-path desktop/src-tauri/Cargo.toml --target aarch64-apple-darwin --exclude-dev check --config deny.toml advisories— passedcargo metadata --locked --manifest-path desktop/src-tauri/Cargo.toml --format-version 1 --no-deps— passedgit diff --check— passedjust ci— root checks, clippy, web/desktop checks and builds, Rust unit suites, and 2,087 desktop tests passed; one unrelated paused-clock timing test failed in the parallel suite, then passed in isolation:cargo test --manifest-path desktop/src-tauri/Cargo.toml relay_admission::tests::concurrent_429_extends_the_window_for_parked_waiters -- --exact --nocaptureScope
This intentionally does not change
nostr-sdk; the bounded advisory fix is the patchednostr-relay-poolrelease already accepted in the root lockfile by #4139.