feat(cli): include display names in channel members - #4461
Open
kiranmagic7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
Contributor
|
looking at this for #4437 — if you're joining display names via users bulk on the same pubkeys from the membership event, that matches how the relay does mention routing. please keep display_name nullable when a profile is missing so tooling can tell "no name" from "not returned". |
Contributor
Author
|
Thanks, that is the contract in this branch now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz channels membersserialized the channel membership tags directly, so each record contained onlypubkeyandrole. This change loads member profiles with one batched kind:0 filter and adds a nullabledisplay_nameto each record while preserving membership order and roles. The profile projection uses the relay's existingnamefallback; missing or malformed profiles producenull.Related issue
Fixes #4437. No duplicate implementation was found; the closest prior CLI mention work is #3330, which does not change
channels membersoutput.Testing
cargo test -p buzz-cli channel_member -- --nocapturecargo test -p buzz-clicargo clippy -p buzz-cli --all-targets --all-features -- -D warningscargo fmt --all -- --checkjust ciAll checks passed. No screenshots are needed for this CLI JSON change.