Skip to content

feat(cli): add --visibility flag to channels update - #5119

Merged
wesbillman merged 1 commit into
mainfrom
lazyjoe/channel-visibility-update
Aug 10, 2026
Merged

feat(cli): add --visibility flag to channels update#5119
wesbillman merged 1 commit into
mainfrom
lazyjoe/channel-visibility-update

Conversation

@cameronhotchkies

Copy link
Copy Markdown
Collaborator

Why

buzz channels update could already change name, description, and TTL, but the SDK/relay/DB path for channel visibility was unreachable from the CLI.

What

  • Add --visibility open|private to buzz channels update
  • Pass the visibility value through to build_update_channel
  • Add guard tests proving empty updates still fail and visibility-only updates are accepted

Risk Assessment

Low — this is limited to the buzz-cli update command and uses existing SDK validation plus existing relay/DB handling.

References

  • Spike notes: RESEARCH/SPIKE_CHANNEL_VISIBILITY_TOGGLE.md
  • Local validation: cargo test -p buzz-cli

Generated with Codex

@cameronhotchkies
cameronhotchkies marked this pull request as ready for review August 6, 2026 22:29
@cameronhotchkies
cameronhotchkies requested a review from a team as a code owner August 6, 2026 22:29
@cameronhotchkies cameronhotchkies added the triage-ready Appropriate for agentic review label Aug 7, 2026
@cameronhotchkies
cameronhotchkies force-pushed the lazyjoe/channel-visibility-update branch 3 times, most recently from 6da70db to 1340361 Compare August 7, 2026 17:28

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing on Wes Billman’s behalf at exact head 134036199cc63ef41df202b418a5555b71c4df65.

The code path is sound, but the commit metadata does not meet this repository’s human-accountability requirement. The sole commit is authored and signed off by Lazy Joe <…@buzz.block.builderlab.xyz> and contains only a matching agent Co-authored-by; no responsible human is the author or signer. DCO being green only proves the agent attested to its own commit—it does not supply the required human sign-off.

Please rewrite the commit so the responsible human is the author and Signed-off-by, with Lazy Joe retained as Co-authored-by, then force-push.

I found no code defect: the typed ChannelVisibility parser constrains input to open|private, visibility-only updates pass the guard, the value reaches the existing SDK builder, and the relay retains its owner/admin authorization boundary. The two new guard tests are appropriate. I also merged this head into current origin/main (07a3c768d) without conflicts and ran the focused guard tests, CLI-definition test, generated --help, formatting, and diff checks successfully.

@wesbillman
wesbillman dismissed their stale review August 10, 2026 21:23

Dismissed because the reviewer applied Wes/Carl collaborative-commit attribution rules too broadly. Repository policy does not require a human author/sign-off for this contributor’s agent-authored commit; DCO is green. The code review found no blocker.

Co-authored-by: Cameron Hotchkies <chotchkies@block.xyz>
Co-authored-by: Lazy Joe <dbd8c9941ba6dafebcef0abc015b65e75d52e7452f2ce483c9c3fd4d180f2504@buzz.block.builderlab.xyz>
Signed-off-by: Cameron Hotchkies <chotchkies@block.xyz>
@cameronhotchkies
cameronhotchkies force-pushed the lazyjoe/channel-visibility-update branch from 1340361 to 7cc0b9a Compare August 10, 2026 21:26
@wesbillman
wesbillman merged commit f8f2ef0 into main Aug 10, 2026
33 checks passed
@wesbillman
wesbillman deleted the lazyjoe/channel-visibility-update branch August 10, 2026 21:48
tellaho added a commit that referenced this pull request Aug 10, 2026
* origin/main:
  chore(release): release Buzz Desktop version 0.5.9 (#5521)
  feat(cli): add --visibility flag to channels update (#5119)

Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
atishpatel added a commit that referenced this pull request Aug 11, 2026
…overy

* origin/main:
  fix(link-preview): reliably render previews sent right after they resolve (#5245)
  fix(link-preview): restore Buzz entity link cards (#5494)
  chore(release): release Buzz Desktop version 0.5.9 (#5521)
  feat(cli): add --visibility flag to channels update (#5119)
  Polish desktop onboarding flow (#5310)
  fix(desktop): quiesce renderer polling while hidden (#3677) (#5490)
  fix(channels): restore member invitations to private channels (#5493)
  perf(ci): experiment with sccache for relay builds (#5224)
  fix(desktop): bound nine unbounded localStorage stores (#5454)
  feat(desktop): time-based sweep for stale localStorage caches (#5453)
  ci(release): gate OSS desktop auto-update promotion (#5398)
  fix(release): pin desktop PR operations to block/buzz (#5212)
  fix(search): surface exact short profile names (#5480)
  Reduce repeated ACP session context (#5423)
  feat(desktop): NIP-AM agent-usage backend — P2 emission/transport/archive + P4a aggregation/D6 (#4000)
  fix(desktop): resolve overlapping member mentions (#5225)

Signed-off-by: Brainy Bumble <0ed7657b57c0e8a9f5288390dd6c8d5d0a3a06abe9b01b9006814f52077d6cdf@buzz.block.builderlab.xyz>
Co-authored-by: Atish Patel <atish@squareup.com>
Signed-off-by: Atish Patel <atish@squareup.com>
wpfleger96 added a commit that referenced this pull request Aug 11, 2026
Bring in main's runtime.rs mesh acp_model wire translation so local
checks and CI both run on the merged tree. Clean auto-merge; the PR's
fail-closed spawn gating and main's model translation touch disjoint
regions of spawn_agent_child.

* origin/main: (24 commits)
  Improve desktop search scoping (#5306)
  Add glass appearance and cohesive settings (#5478)
  Add Send to channel for thread messages (#5305)
  Fix macOS attachment picker lifecycle and allow inert HTML downloads (#5569)
  fix(desktop): preserve fresh channel timelines (#5577)
  fix(desktop): suppress fresh focus-return refetches for channels and home-feed (#5535)
  chore: mesh upgrade, clean up legacy special case code, simplify model selection for mesh (#5289)
  fix(desktop): preserve theme when opening communities (#5266)
  fix(link-preview): resolve YouTube videos through oEmbed (#5520)
  fix(buzz-agent): harden Databricks OAuth token cache and callback (#5534)
  fix(link-preview): reliably render previews sent right after they resolve (#5245)
  fix(link-preview): restore Buzz entity link cards (#5494)
  chore(release): release Buzz Desktop version 0.5.9 (#5521)
  feat(cli): add --visibility flag to channels update (#5119)
  Polish desktop onboarding flow (#5310)
  fix(desktop): quiesce renderer polling while hidden (#3677) (#5490)
  fix(channels): restore member invitations to private channels (#5493)
  perf(ci): experiment with sccache for relay builds (#5224)
  fix(desktop): bound nine unbounded localStorage stores (#5454)
  feat(desktop): time-based sweep for stale localStorage caches (#5453)
  ...

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage-ready Appropriate for agentic review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants