fix: preserve materials frontmatter in serializeNode - #229
Merged
Conversation
nahiyankhan
marked this pull request as ready for review
July 14, 2026 00:35
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Saving a Ghost node no longer silently deletes its
materialsfrontmatter.Problem:
serializeNodeemitted onlydescriptioninto frontmatter, so any serialize round-trip dropped a node'smaterialslocators. A downstream consumer (Ether) verified this against the lib source and had to splicematerialsback in after serializing.Solution: Emit
materialsafterdescriptionin the stable key order, so round-trips are lossless and diffs stay deterministic.Validation:
pnpm test: 175 passed, 1 skipped (run in main checkout with identical diff; this worktree's install was blocked by a registry proxy issue)pnpm check: greennode-schema.test.tsrun: 13 passed, including the new materials round-trip testChangeset: added (
patch)Ghost Review:
ghost check/ghost review: not run because the change is a pure serialization fix in ghost-core with no UI or fingerprint surface impactFile changes
packages/ghost/src/ghost-core/node/serialize.ts
Emit
materialsinto ordered frontmatter when defined; update the doc comment to reflect the stable key order.packages/ghost/test/ghost-core/node-schema.test.ts
New round-trip test asserting
materials(repo glob + HTTPS URL) survives serialize/parse..changeset/serialize-node-materials.md
Patch changeset for
@design-intelligence/ghost.Screenshots/Demos: N/A