Tag Proto Fleet PR-eligible E2E scenarios

[edgars-avotins]

Reviewable diff: +0/-0 across 0 files (excludes generated, test, and story files).

Summary

This PR marks the Proto Fleet Playwright scenarios we want included in the default pull-request subset by appending @pr to their test titles. It does not change product behavior or test logic; it only labels a representative slice of the existing suite so we can wire PR-vs-nightly selection around explicit tags and see how that shape behaves in CI.

How it works

Each selected scenario keeps its existing flow and assertions, but its title now includes @pr. The tagged set covers 61 of the 130 non-setup, non-visual Proto Fleet scenarios, which keeps broad feature coverage while trimming the default PR set down to roughly the 1/3-to-1/2 range we discussed.

Diagrams

flowchart TD
  A["Proto Fleet spec file"] --> B["Existing scenarios"]
  B --> C["Selected representative scenarios get @pr tag"]
  C --> D["Future PR selection can target tagged scenarios"]
  B --> E["Untagged scenarios remain available for nightly/full runs"]

Loading

Areas of the code involved

Area / package / file	What changed	Why it matters for review
client/e2eTests/protoFleet/spec/**	Added @pr suffixes to selected test titles across the Proto Fleet E2E specs.	Review should focus on whether the chosen subset is representative and balanced, since no assertions or page-object behavior changed.

Key technical decisions & trade-offs

• Tag individual scenarios instead of splitting files immediately, so we can shape PR coverage without duplicating hooks or setup flows first.
• Keep at least one tagged scenario in each meaningful area/spec where practical, instead of over-optimizing solely for runtime.
• Leave the alerts spec untagged for now because it still depends on its special environment gate and is not part of the normal PR path today.

Testing & validation

• ./node_modules/.bin/eslint on the touched Proto Fleet spec files
• Push hook client-typecheck passed when the branch was pushed
• No Playwright rerun, because this change only updates test titles and does not alter test behavior

[github-actions]

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

• Reviewed pull request diff only (8ea04bcfcbf267c4726043530a6003e4e85b44da...9eb0ec9b20c0b163b754a110d3eca3c558bcb8fc, exact PR three-dot diff)
• Model: gpt-5.6-sol

💡 Click "edited" above to see previous reviews for this PR.

---

Review Summary

Overall Risk: MEDIUM

Findings

[MEDIUM] Security-sensitive E2E scenarios no longer block merges

• Category: Reliability
• Location: .github/workflows/pr-gate.yml:171
• Description: The blocking PR and merge-queue workflow now runs only tests tagged @smoke. Only 55 of 132 target test declarations are tagged. Excluded scenarios include pool-update authorization, curtailment-ingest denial, administrative user/role management, and several miner permissions.
• Impact: Regressions in authorization and mining-pool workflows can pass every pre-merge gate and reach main; the full scheduled suite detects them only after merge.
• Recommendation: Keep security- and payout-sensitive scenarios in the blocking set. Run the full suite for RBAC, pool, authentication, and permission-related changes, or supplement smoke tests with every changed spec and enforce coverage for newly added scenarios.

Notes

Scheduled and manually dispatched workflows still default to the full suite, and the Playwright filtering preserves setup-project dependencies. Two mobile visual baselines also changed and should receive the repository-required human image review before merge.

---

_{Generated by Codex Security Review |
Triggered by: @edgars-avotins |
Review workflow run}

[Copilot]

🟢 Ready to approve

The changes are limited to scenario title tagging/formatting and do not alter test behavior or shared helpers.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR updates the Proto Fleet Playwright E2E suite by appending @pr to selected scenario titles so they can be included in a future default PR-focused test subset without changing test logic or product behavior.

Changes:

• Appended @pr to selected Playwright test(...) titles across Proto Fleet E2E spec files.
• Applied minor formatting (multi-line argument destructuring) where needed after title updates.

File summaries

File	Description
client/e2eTests/protoFleet/spec/teamAccounts.spec.ts	Tag selected Team Accounts scenarios with @pr.
client/e2eTests/protoFleet/spec/sitesDetail.spec.ts	Tag the primary Site detail scenario with @pr.
client/e2eTests/protoFleet/spec/singleMinerView.spec.ts	Tag key fleet-hosted single-miner navigation scenarios with @pr.
client/e2eTests/protoFleet/spec/serverLogs.spec.ts	Tag Server Logs happy-path and error-path scenarios with @pr.
client/e2eTests/protoFleet/spec/securitySettings.spec.ts	Tag the admin credential update scenario with @pr (plus formatting).
client/e2eTests/protoFleet/spec/schedulesSettings.spec.ts	Tag schedule CRUD and validation scenarios with @pr.
client/e2eTests/protoFleet/spec/rbacMiners.spec.ts	Tag representative miner RBAC scenarios with @pr.
client/e2eTests/protoFleet/spec/rbacAdmin.spec.ts	Tag representative admin RBAC scenarios with @pr (plus formatting).
client/e2eTests/protoFleet/spec/rbac.spec.ts	Tag representative RBAC scenarios with @pr.
client/e2eTests/protoFleet/spec/racksOverviewActions.spec.ts	Tag rack overview action scenarios with @pr (plus formatting).
client/e2eTests/protoFleet/spec/racksManualAssignment.spec.ts	Tag manual rack assignment scenario with @pr (plus formatting).
client/e2eTests/protoFleet/spec/racksManagement.spec.ts	Tag racks management scenario with @pr.
client/e2eTests/protoFleet/spec/racksCreation.spec.ts	Tag rack creation/numbering scenarios with @pr.
client/e2eTests/protoFleet/spec/minersSleepWake.spec.ts	Tag miner sleep/wake scenarios with @pr.
client/e2eTests/protoFleet/spec/minersSettingsActions.spec.ts	Tag miner settings action scenarios with @pr.
client/e2eTests/protoFleet/spec/minersRename.spec.ts	Tag representative rename scenarios with @pr.
client/e2eTests/protoFleet/spec/minersFiltersViews.spec.ts	Tag filters + saved-views scenarios with @pr (plus formatting).
client/e2eTests/protoFleet/spec/minersAddRemove.spec.ts	Tag unpair/add single miner scenario with @pr.
client/e2eTests/protoFleet/spec/minersActions.spec.ts	Tag representative miners action scenarios with @pr.
client/e2eTests/protoFleet/spec/minerIssues.spec.ts	Tag miner issues scenario with @pr.
client/e2eTests/protoFleet/spec/groups.spec.ts	Tag representative groups scenarios with @pr.
client/e2eTests/protoFleet/spec/generalSettings.spec.ts	Tag general settings scenarios with @pr.
client/e2eTests/protoFleet/spec/fleetSavedViews.spec.ts	Tag fleet saved view scenario with @pr.
client/e2eTests/protoFleet/spec/fleetFilters.spec.ts	Tag fleet filters scenarios with @pr.
client/e2eTests/protoFleet/spec/firmware.spec.ts	Tag firmware upload/update scenario with @pr.
client/e2eTests/protoFleet/spec/dashboard.spec.ts	Tag dashboard shell render scenario with @pr.
client/e2eTests/protoFleet/spec/curtailmentSettings.spec.ts	Tag curtailment settings scenario with @pr.
client/e2eTests/protoFleet/spec/curtailment.spec.ts	Tag whole-fleet curtailment scenario with @pr.
client/e2eTests/protoFleet/spec/buildings.spec.ts	Tag representative buildings scenarios with @pr.
client/e2eTests/protoFleet/spec/buildingDetail.spec.ts	Tag building detail scenario with @pr.
client/e2eTests/protoFleet/spec/auth.spec.ts	Tag admin sign-in scenario with @pr.
client/e2eTests/protoFleet/spec/apiKeysSettings.spec.ts	Tag API key create/revoke scenario with @pr.
client/e2eTests/protoFleet/spec/addMinersValidation.spec.ts	Tag add-miners validation scenarios with @pr.
client/e2eTests/protoFleet/spec/activityLogin.spec.ts	Tag activity login audit scenario with @pr.
client/e2eTests/protoFleet/spec/activity.spec.ts	Tag representative activity scenarios with @pr.

Review details

• Files reviewed: 35/35 changed files
• Comments generated: 0
• Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a87d65348

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[mcharles-square]

I'm not convinced that this approach of adding @pr to the test name is the best approach for tagging fast tests. Have you considered using the native test annotations? ie { tag: "smoke" } (using smoke here instead of pr since smoke or fast is usually how these kinds of tests get tagged)

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9eb0ec9b20

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".