-
Notifications
You must be signed in to change notification settings - Fork 24
update node setup to docker and switch validator keys to hash-sig #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7fccd83
chore: adds gean validator config
mananuf 810dee7
chore: adds gean to client cmd
mananuf 1932a65
Merge branch 'main' of github.com:geanlabs/lean-quickstart into add-g…
mananuf f1d009d
chore: adds isAgreggator flag
mananuf ec8fce9
fix(chore):update node Docker image to devnet1
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Metrics enabled by default if not strictly disabled | ||
| metrics_flag="" | ||
| if [ "$enableMetrics" != "false" ]; then | ||
| metrics_flag="--metrics-port $metricsPort" | ||
| fi | ||
|
|
||
| # Gean uses --listen-addr for libp2p (TCP) and --discovery-port for Discv5 (UDP) | ||
| # We map $quicPort to the TCP listen port for consistency in port allocation | ||
|
|
||
| # Resolve binary path relative to the script location | ||
| # Fallback to absolute path if scriptDir is not available | ||
| BASE_DIR="${scriptDir:-$(pwd)}" | ||
| gean_bin="$BASE_DIR/../gean/bin/gean" | ||
|
|
||
| node_binary="$gean_bin \ | ||
| --data-dir \"$dataDir/$item\" \ | ||
| --genesis \"$configDir/config.yaml\" \ | ||
| --bootnodes \"$configDir/nodes.yaml\" \ | ||
| --validator-registry-path \"$configDir/validators.yaml\" \ | ||
| --node-id \"$item\" \ | ||
| --node-key \"$configDir/$privKeyPath\" \ | ||
| --validator-keys \"$configDir/hash-sig-keys\" \ | ||
| --listen-addr \"/ip4/0.0.0.0/tcp/$quicPort\" \ | ||
| --discovery-port $quicPort \ | ||
| --devnet-id \"${devnet:-devnet0}\" \ | ||
| $metrics_flag" | ||
|
|
||
| # Docker command (assumes image entrypoint handles the binary) | ||
| node_docker="ghcr.io/geanlabs/gean:devnet1 \ | ||
| --data-dir /data \ | ||
| --genesis /config/config.yaml \ | ||
| --bootnodes /config/nodes.yaml \ | ||
| --validator-registry-path /config/validators.yaml \ | ||
| --node-id $item \ | ||
| --node-key /config/$privKeyPath \ | ||
| --validator-keys /config/hash-sig-keys \ | ||
| --listen-addr /ip4/0.0.0.0/tcp/$quicPort \ | ||
| --discovery-port $quicPort \ | ||
| --devnet-id ${devnet:-devnet0} \ | ||
| $metrics_flag" | ||
|
|
||
| node_setup="docker" # Default to binary for now as per user workflow | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a
devnet3image? We are no longer testing or supporting the earlier devnets.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. We’ll go ahead and close this PR and realign our changes with the currently supported devnet.