You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. Docker image extraction pattern
The guide’s template extracts the image from ^node_docker=... with a grep -oE '...image:tag'. Peam’s node_docker starts with "$peam_docker_image \, so that pattern wouldn’t work; the role correctly uses a custom peam_docker_image= + sed. Consider either documenting this variant in the guide or reshaping node_docker so the standard extraction still applies.
2. Image tag inconsistency ansible/roles/peam/defaults/main.yml uses ghcr.io/malik672/peam:sha-c29d566 while client-cmds/peam-cmd.sh defaults to ghcr.io/malik672/peam:sha-7ad325c. Ansible fallback and local spin-node can disagree on which image runs — worth aligning on a single tag.
3. metricsPort and apiPort both 5059
The doc’s examples use distinct ports for metrics vs HTTP API. Unless Peam serves both on one listener, this may fail at bind time or confuse scraping; consider splitting (e.g. metrics on a high port, API on 505x).
Yes, peam supports Prometheus metrics. It exposes a /metrics endpoint and now uses a separate metrics port in quickstart/ansible (metricsPort) from the HTTP API port (apiPort).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Peam to lean-quickstart as a supported local devnet client.