Skip to content

refAllDeclsRecursive-fix #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gballet merged 2 commits into from
Nov 16, 2025
Merged

refAllDeclsRecursive-fix #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f7c46
refAllDeclsRecursive-fix
chetanyb Nov 1, 2025
5108113
review feedback
gballet Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/utils.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,20 @@ pub fn List(comptime T: type, comptime N: usize) type {
return .{ .inner = Inner.init(allocator) };
}

pub fn eql(self: *const Self, other: *Self) bool {
return std.mem.eql(Self.Item, self.constSlice(), other.constSlice());
pub fn eql(self: *const Self, other: *const Self) bool {
if (self.len() != other.len()) return false;

const self_slice = self.constSlice();
const other_slice = other.constSlice();

// For struct/array types, use std.meta.eql for proper deep comparison
if (@typeInfo(Self.Item) == .@"struct" or @typeInfo(Self.Item) == .array) {
return std.meta.eql(self_slice, other_slice);
} else {
// For a slice of primitive types, it's faster to do a memory
// comparison.
return std.mem.eql(Self.Item, self_slice, other_slice);
}
}

pub fn deinit(self: *Self) void {
Expand Down Expand Up @@ -303,7 +315,7 @@ pub fn Bitlist(comptime N: usize) type {
self.inner.deinit();
}

pub fn eql(self: *const Self, other: *Self) bool {
pub fn eql(self: *const Self, other: *const Self) bool {
return (self.length == other.length) and std.mem.eql(u8, self.inner.items, other.inner.items);
}

Expand Down