Open
Conversation
Feat/new menu tab
fix: minor bugs and front-end glitches
fix: wrong state reset when navigating through grants
feat: grant-review
…ments-code update: card-new-review doc & code improvement
FrancoAguzzi
suggested changes
Sep 6, 2024
| } | ||
| } | ||
|
|
||
| export function getNetworkImage(network: string, themeMode: ThemeMode) { |
There was a problem hiding this comment.
If this did not include a Theme, it could be reused in many other places as well ;)
Author
There was a problem hiding this comment.
Do you think I should change that to something else?
There was a problem hiding this comment.
Yes! Remove the theme spec and reuse it whenever the rest of the code is referenced: you will see that multiple things places more will use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hextypes and replaced type aliasinggetNetworkImageto make code cleaner