bug example

[KacperKoza343]

Bug Scenario

Let's analyze a case where a post is incorrectly skipped:

Initial settings:

• POST_INTERVAL_MIN = 90 minutes
• POST_INTERVAL_MAX = 180 minutes

Timeline:

1. 10:00 AM - First post is published

   • lastPostTimestamp = 10:00 AM
   • Generates delay = 150 minutes
   • Schedules next execution for 12:30 PM (after 150 minutes)

2. 12:30 PM - generatePostLoop executes

   • Generates NEW delay = 170 minutes
   • Checks: Date.now() (12:30 PM) > lastPostTimestamp (10:00 AM) + newDelay (170 minutes)?
   • 12:30 PM > 12:50 PM? → NO
   • shouldPost = false
   • Schedules next check for 15:20 PM (after 170 minutes)

The bug occurs because:

1. The decision to publish the current post is based on a NEWLY generated delay
2. If the new delay is longer than the previous one, the post won't be published even though the scheduled time has passed
3. This leads to extended gaps between posts that can exceed POST_INTERVAL_MAX

Root cause:
The current implementation incorrectly ties the execution of the current post to the random delay generation for the next post. These should be separate concerns - the current post should be published based on the previously scheduled delay, while the new delay should only determine the timing of the next post.

Code in this PR saves some additional records to DB to track posts publications in Instagram Client, client was running with theses intervals:

POST_INTERVAL_MIN=15
POST_INTERVAL_MAX=20

In result we can see that one post was skipped:

Similar behaviour may happen in clients where this condition occurs:

   if (Date.now() > lastPostTimestamp + delay) {

That is:

• Instagram client
• twitter client
• farcaster client

[github-actions]

This pull request has been automatically marked as stale due to 30 days of inactivity.
If no further activity occurs within 7 days, it will be closed automatically. Please take action if this pull request is still relevant.