Pre release code cleanup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the application version to 0.1.4 - Refactor key generation logic for Qubic seed and public key
- Added optimization option in Makefile - Updated encoding, decoding, Montgomery conversion functions in crypto_util.c
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| table_lookup_fixed_base(((point_precomp_t*)&FIXED_BASE_TABLE)+(v-j-1)*(1 << (w-1)), S, digit, digits[d-j*e+ii-e]); | ||
| eccmadd(S, R); // R = R+S using representations (X,Y,Z,Ta,Tb) <- (X,Y,Z,Ta,Tb) + (x+y,y-x,2dt) | ||
| table_lookup_fixed_base( | ||
| ((point_precomp_t*) &FIXED_BASE_TABLE) + (v - j - 1) * (1 << (w - 1)), |
Check failure
Code scanning / CodeQL
Suspicious pointer scaling High
| for (j = 1; j < NWORDS64_ORDER; j++) { | ||
| scalar[j] = scalar[j] + carry; | ||
| carry = (carry & (uint64_t) is_digit_zero_ct( | ||
| (digit_t) scalar[j])); // carry = (scalar[j] < temp); |
Check notice
Code scanning / CodeQL
Commented-out code Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 days ago
To fix the problem, we should remove the commented-out code. This will make the code cleaner and reduce potential confusion for future developers. The specific change involves deleting the line // carry = (scalar[j] < temp); from the file deps/FourQ_ARM/eccp2.c.
Suggested changeset
1
deps/FourQ_ARM/eccp2.c
| @@ -884,4 +884,4 @@ | ||
| scalar[j] = scalar[j] + carry; | ||
| carry = (carry & (uint64_t) is_digit_zero_ct( | ||
| (digit_t) scalar[j])); // carry = (scalar[j] < temp); | ||
| carry = (carry & (uint64_t) is_digit_zero_ct( | ||
| (digit_t) scalar[j])); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
The test for app version has been updated. The expected version number was previously "0.1.2", but it has now been changed to "0.1.4". This change ensures that the test is aligned with the current application version.
0xMMBD
force-pushed
the
pre-release-code-cleanup
branch
from
38c4289 to
d93ffed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.