You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the listing map search below listing results a set of content cards can now be displayed
This is similar to what Doorway currently has
The three resource cards from the home page will appear here if they are turned on for the jurisdiction. Additionally a new custom content card can be added. This card(s) will display if the text string exist in the general overrides file.
How Can This Be Tested/Reviewed?
This is only visible in the map view so the easiest way to do that is to use the Bridge Bay jurisdiction:
Seed using the "region" configuration: yarn db:setup:staging-region
Set the jurisdiction env variable for the public site to be "Bridge Bay".
Go to the listings page and see the cards at the bottom of the right rail.
To test all of the cards you will want to also turn on enableAdditionalResources and enableResources
Author Checklist:
Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
@emilyjablonski The change is a recommendation from Hannan. The furthest right version is what was decided.
It looks like I need to fine tune the results because there are a couple of cases the images are shorter than the max height when addresses are short and there are no tags
@ludtkemorgan It looks like it's still the case that not all images in the list are the same height, not sure if that's an issue or acceptable given the updates to design, but this otherwise lgtm! Lmk if you wanna move forward, it's only like a 10% difference in height
@emilyjablonski I should have updated the PR description. Having every image be the exact same height ran into a few weird cases depending on the content. So instead it was decided that there is a little bit of wiggle room. The images can now be between 176px and 192px. That way it's more likely to align with the bottom of the content but the small content cards and large content cards don't have it aligned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready to mergeShould be applied when a PR has been reviewed and approved
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5987
Description
On the listing map search below listing results a set of content cards can now be displayed

This is similar to what Doorway currently has

The three resource cards from the home page will appear here if they are turned on for the jurisdiction. Additionally a new custom content card can be added. This card(s) will display if the text string exist in the general overrides file.
How Can This Be Tested/Reviewed?
This is only visible in the map view so the easiest way to do that is to use the Bridge Bay jurisdiction:
yarn db:setup:staging-regionenableAdditionalResourcesandenableResourcesAuthor Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: