Skip to content

fix: map view dynamic cards#6431

Merged
ludtkemorgan merged 11 commits into
mainfrom
5987/dynamic-listing-cards
Jul 14, 2026
Merged

fix: map view dynamic cards#6431
ludtkemorgan merged 11 commits into
mainfrom
5987/dynamic-listing-cards

Conversation

@ludtkemorgan

@ludtkemorgan ludtkemorgan commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This PR addresses #5987

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

On the listing map search below listing results a set of content cards can now be displayed
image

This is similar to what Doorway currently has
image

The three resource cards from the home page will appear here if they are turned on for the jurisdiction. Additionally a new custom content card can be added. This card(s) will display if the text string exist in the general overrides file.

How Can This Be Tested/Reviewed?

This is only visible in the map view so the easiest way to do that is to use the Bridge Bay jurisdiction:

  1. Seed using the "region" configuration: yarn db:setup:staging-region
  2. Set the jurisdiction env variable for the public site to be "Bridge Bay".
  3. Go to the listings page and see the cards at the bottom of the right rail.
  4. To test all of the cards you will want to also turn on enableAdditionalResources and enableResources

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify

netlify Bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit 11d3e9e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a565f8260c2dd000876d388

Comment thread api/prisma/seed-staging/seed-bridge-bay.ts
@netlify

netlify Bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 11d3e9e
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a565f82edf37b000838257a
😎 Deploy Preview https://deploy-preview-6431--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 11d3e9e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a565f82cf99c8000801533d
😎 Deploy Preview https://deploy-preview-6431--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 7278ea5
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6a3ee5061876fa00082d79ad
😎 Deploy Preview https://deploy-preview-6431--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ludtkemorgan
ludtkemorgan force-pushed the 5987/dynamic-listing-cards branch from 7384d3c to 3d15e9d Compare June 22, 2026 22:01
@ludtkemorgan ludtkemorgan changed the title 5987/dynamic listing cards fix: map view dynamic cards Jun 23, 2026
@ludtkemorgan
ludtkemorgan force-pushed the 5987/dynamic-listing-cards branch from 5481b6e to e067dc3 Compare June 23, 2026 17:58
@ludtkemorgan
ludtkemorgan marked this pull request as ready for review June 23, 2026 17:58
@ludtkemorgan ludtkemorgan added the 1 review needed Requires 1 more review before ready to merge label Jun 23, 2026
Comment thread sites/public/src/components/browse/map/MapListingCard.module.scss
@ludtkemorgan
ludtkemorgan force-pushed the 5987/dynamic-listing-cards branch from d2f7f2f to 7278ea5 Compare June 26, 2026 20:45
Comment thread sites/public/page_content/locale_overrides/general.json Outdated
Comment thread sites/public/page_content/locale_overrides/general.json
Comment thread sites/public/src/components/browse/map/ListingsCombined.module.scss Outdated
Comment thread sites/public/src/components/browse/map/ListingsCombined.module.scss Outdated
Comment thread sites/public/src/components/browse/map/ListingsCombined.module.scss Outdated

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) Looks like there's a visual regression on the pin popup
Main:
Screenshot 2026-06-30 at 8 45 13 PM

Branch:
Image

(2) Testing this in the browser, I really prefer the behavior on main - can you remind me what is driving this change?

Main:
Screenshot 2026-06-30 at 8 45 06 PM

Branch:
Screenshot 2026-06-30 at 8 47 06 PM

@emilyjablonski emilyjablonski added questions and removed 1 review needed Requires 1 more review before ready to merge labels Jul 1, 2026
@ludtkemorgan

Copy link
Copy Markdown
Collaborator Author

@emilyjablonski The change is a recommendation from Hannan. The furthest right version is what was decided.
listing card layout in map view

It looks like I need to fine tune the results because there are a couple of cases the images are shorter than the max height when addresses are short and there are no tags

@ludtkemorgan
ludtkemorgan force-pushed the 5987/dynamic-listing-cards branch from 352584c to 091e6e6 Compare July 1, 2026 20:19
@ludtkemorgan ludtkemorgan added 1 review needed Requires 1 more review before ready to merge and removed questions labels Jul 1, 2026
@ludtkemorgan

Copy link
Copy Markdown
Collaborator Author

@emilyjablonski this is ready to be re-reviewed. Let me know if you have any questions

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Those updates look good! I'm seeing a regression on the padding on the mobile card though

@emilyjablonski emilyjablonski added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Jul 2, 2026
@ludtkemorgan
ludtkemorgan force-pushed the 5987/dynamic-listing-cards branch from 091e6e6 to fd4ef00 Compare July 8, 2026 13:37
@ludtkemorgan ludtkemorgan removed the needs changes The author must make changes and then re-request review before merging label Jul 8, 2026
@ludtkemorgan ludtkemorgan added the 1 review needed Requires 1 more review before ready to merge label Jul 8, 2026
@ludtkemorgan
ludtkemorgan force-pushed the 5987/dynamic-listing-cards branch from fd4ef00 to 8ecc639 Compare July 10, 2026 18:32
@emilyjablonski

emilyjablonski commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

@ludtkemorgan It looks like it's still the case that not all images in the list are the same height, not sure if that's an issue or acceptable given the updates to design, but this otherwise lgtm! Lmk if you wanna move forward, it's only like a 10% difference in height
Screenshot 2026-07-14 at 9 56 14 AM

@ludtkemorgan

Copy link
Copy Markdown
Collaborator Author

@emilyjablonski I should have updated the PR description. Having every image be the exact same height ran into a few weird cases depending on the content. So instead it was decided that there is a little bit of wiggle room. The images can now be between 176px and 192px. That way it's more likely to align with the bottom of the content but the small content cards and large content cards don't have it aligned

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jul 14, 2026
@ludtkemorgan
ludtkemorgan force-pushed the 5987/dynamic-listing-cards branch from 8ecc639 to 11d3e9e Compare July 14, 2026 16:10
@ludtkemorgan
ludtkemorgan merged commit cc03adf into main Jul 14, 2026
25 checks passed
@ludtkemorgan
ludtkemorgan deleted the 5987/dynamic-listing-cards branch July 14, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants