fix: add optional disclaimer to account edit pages#6455
Conversation
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
praise: In order for us to be able to remove these in a fork and not mess with alignment in the core translations files, these strings have to live only in the public overrides files
There was a problem hiding this comment.
Oops, it looks like my last commit didn't have the files in the override folder despite me updating that in the PR description 🤦 . I put empty strings in all of the languages and tested it out. It works as expected. The tIfExists returns null as expected so nothing gets rendered (That's why I accidentally pushed up that console log to test it) and if removed it renders the default string.
My preference would be to have default text in the main translation files and then strings that we anticipate to have turned off by default to override to empty in the override folder. That way we know that it exists with an example of the text, but it won't impact any other jurisdiction. I know you mentioned earlier there is an issue with this route so let me know if I'm missing something
| } | ||
|
|
||
| .account-settings-disclaimer { | ||
| font-size: var(--seeds-font-size-xs); |
There was a problem hiding this comment.
note: Can this be at least one size bigger since it's presented as body text and not a sub-label to another element? Our xs pushes the boundaries of a11y limits and is usually only used for really intentional hierarchy
There was a problem hiding this comment.
For sure! This was ported over directly from Doorway. Do you have documentation on when to use each font-size?
emilyjablonski
left a comment
There was a problem hiding this comment.
Left a few comments!
cd886c5 to
5f4001c
Compare
This PR addresses #6235
Description
Doorway has a disclaimer at the bottom of the public edit account page. This PR adds the ability to have a disclaimer show on the page if the translation string exists.
How Can This Be Tested/Reviewed?
The following scenarios should be tested:
No disclaimer:
Disclaimer on
Delete the
"account.settings.disclaimer": "",line from the public override file4. Login as a public user. Go to edit your account http://localhost:3000/account/edit and verify that the disclaimer is at the bottom of the page
5. Login as an advocate user. Go to edit your account http://localhost:3000/account/edit and verify that the disclaimer is at the bottom of the page
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: