Skip to content

fix: add optional disclaimer to account edit pages#6455

Open
ludtkemorgan wants to merge 3 commits into
mainfrom
6235/data-disclaimer
Open

fix: add optional disclaimer to account edit pages#6455
ludtkemorgan wants to merge 3 commits into
mainfrom
6235/data-disclaimer

Conversation

@ludtkemorgan

Copy link
Copy Markdown
Collaborator

This PR addresses #6235

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Doorway has a disclaimer at the bottom of the public edit account page. This PR adds the ability to have a disclaimer show on the page if the translation string exists.

image

How Can This Be Tested/Reviewed?

The following scenarios should be tested:

No disclaimer:

  1. Login as a public user. Go to edit your account http://localhost:3000/account/edit and verify that there is no disclaimer
  2. Login as an advocate user. Go to edit your account http://localhost:3000/account/edit and verify that there is no disclaimer

Disclaimer on

Delete the "account.settings.disclaimer": "", line from the public override file
4. Login as a public user. Go to edit your account http://localhost:3000/account/edit and verify that the disclaimer is at the bottom of the page
5. Login as an advocate user. Go to edit your account http://localhost:3000/account/edit and verify that the disclaimer is at the bottom of the page

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 5f4001c
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a4bb988fc4e8300080dfe49
😎 Deploy Preview https://deploy-preview-6455--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ludtkemorgan ludtkemorgan added the 1 review needed Requires 1 more review before ready to merge label Jun 30, 2026
@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 5f4001c
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a4bb988f77e220008dd6b8d
😎 Deploy Preview https://deploy-preview-6455--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 5f4001c
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a4bb988528f4c0008a43ebb
😎 Deploy Preview https://deploy-preview-6455--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit cd886c5
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6a443ffb255fba00082d23cb
😎 Deploy Preview https://deploy-preview-6455--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: In order for us to be able to remove these in a fork and not mess with alignment in the core translations files, these strings have to live only in the public overrides files

@ludtkemorgan ludtkemorgan Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it looks like my last commit didn't have the files in the override folder despite me updating that in the PR description 🤦 . I put empty strings in all of the languages and tested it out. It works as expected. The tIfExists returns null as expected so nothing gets rendered (That's why I accidentally pushed up that console log to test it) and if removed it renders the default string.

My preference would be to have default text in the main translation files and then strings that we anticipate to have turned off by default to override to empty in the override folder. That way we know that it exists with an example of the text, but it won't impact any other jurisdiction. I know you mentioned earlier there is an issue with this route so let me know if I'm missing something

Comment thread sites/public/src/components/account/EditPublicAccount.tsx Outdated
}

.account-settings-disclaimer {
font-size: var(--seeds-font-size-xs);

@emilyjablonski emilyjablonski Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Can this be at least one size bigger since it's presented as body text and not a sub-label to another element? Our xs pushes the boundaries of a11y limits and is usually only used for really intentional hierarchy

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure! This was ported over directly from Doorway. Do you have documentation on when to use each font-size?

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments!

@emilyjablonski emilyjablonski added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Jul 3, 2026
@ludtkemorgan
ludtkemorgan force-pushed the 6235/data-disclaimer branch from cd886c5 to 5f4001c Compare July 6, 2026 14:19
@ludtkemorgan ludtkemorgan added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 review needed Requires 1 more review before ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants