Skip to content

feat: display external listings on public site#6500

Merged
mcgarrye merged 3 commits into
mainfrom
6366/display-external-listings-on-public
Jul 16, 2026
Merged

feat: display external listings on public site#6500
mcgarrye merged 3 commits into
mainfrom
6366/display-external-listings-on-public

Conversation

@mcgarrye

@mcgarrye mcgarrye commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

This PR addresses #(6366) #(6501)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The public site sets the listing filter includeExternal to true for the listing browse page (listingBrowse and listingSearchCombined)

When testing with live staging data, it was found that the assets field on the listing table was being field with bad data. This field is no longer used so the solution was to clean up all code usages of the field. It is still required in the db on create so it is set to Prisma.JsonNullValueInput.JsonNull. Tests were updated accordingly. A follow-up ticket to make the db changes exists here.

How Can This Be Tested/Reviewed?

With Bloomington:

  • Run yarn setup
  • On the public site, navigate to the listings browse page
  • Confirm listings appear as normal
  • Sign in as an admin through the partners site or the api
  • Through the api, call the /externalListings/ingest endpoint with the relevant data (found below)
  • Return to the listings browse page and reload
  • Confirm external listings are displaying
  • Test the filters, external listings do not have Accessibility features

With `Bridge Bay:

  • Run yarn db:setup:staging-region
  • On the public site, navigate to the listings browse page
  • Confirm listings appear as normal
  • Sign in as an admin through the partners site or the api
  • Through the api, call the /externalListings/ingest endpoint with the relevant data (found below)
  • Return to the listings browse page and reload
  • Confirm external listings are displaying in both the side panel and the map view
  • Test all filters

Call the ingest endpoint with the following payload, using the desired jurisdiction id to associate the listings with:
{ "externalURL": "https://hba-0-3-alameda-staging.herokuapp.com/", "jurisdictionId": "{id}", "targetName": "San Jose" }

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit b9f53b5
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a57f2c35673b60008b19acd

@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit b9f53b5
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a57f2c35673b60008b19ac8
😎 Deploy Preview https://deploy-preview-6500--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mcgarrye mcgarrye requested a review from ludtkemorgan July 14, 2026 20:21
@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit b9f53b5
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a57f2c3deddd500081c3a8e
😎 Deploy Preview https://deploy-preview-6500--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mcgarrye mcgarrye added the 1 review needed Requires 1 more review before ready to merge label Jul 15, 2026

@ludtkemorgan ludtkemorgan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great! only thing I ran into was I copied the sample body for the ingest endpoint and it gave a 500. It doesn't like if you have a trailing / on the externalURL. Not an issue with the code, we'll just want to be careful when setting it up

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jul 15, 2026
@mcgarrye mcgarrye merged commit 1f9e7f8 into main Jul 16, 2026
25 checks passed
@mcgarrye mcgarrye deleted the 6366/display-external-listings-on-public branch July 16, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants