Skip to content

6378/validate csv#6524

Draft
matzduniuk wants to merge 35 commits into
mainfrom
6378/validate-csv
Draft

6378/validate csv#6524
matzduniuk wants to merge 35 commits into
mainfrom
6378/validate-csv

Conversation

@matzduniuk

Copy link
Copy Markdown
Collaborator

This PR addresses #6378

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

  • Adds a new endpoint to the application controller.
  • Adds a comprehensive validation method for the incoming bulk application CSV file to the bulk upload service.
  • Add integration tests for CSV validation methods
  • Adds a new S3 service method for retrieving a CSV file from a private S3 bucket

How Can This Be Tested/Reviewed?

Note

At the moment, testing of this branch is reduced to verifying the coverage of the included integration tests or by preparing a mock CSV file directly in the S3 bucket

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@matzduniuk matzduniuk self-assigned this Jul 16, 2026
@matzduniuk matzduniuk added wip This PR is not ready for review, do not review it's a “Work In Progress” 1 review needed Requires 1 more review before ready to merge labels Jul 16, 2026
@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit f68dc50
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a59e99a4632e20008c4cf95

@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit f68dc50
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a59e99a82c2dc0008dbfeb2
😎 Deploy Preview https://deploy-preview-6524--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit f68dc50
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a59e99a41b47500083b6a99
😎 Deploy Preview https://deploy-preview-6524--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 review needed Requires 1 more review before ready to merge wip This PR is not ready for review, do not review it's a “Work In Progress”

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant