feat: public listing detail page supports external listings#6525
feat: public listing detail page supports external listings#6525mcgarrye wants to merge 1 commit into
Conversation
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
left a comment
ludtkemorgan
left a comment
There was a problem hiding this comment.
This looks good after a padding is added to the new disclaimer
| "listings.apply.applicationSeason": "Residents should apply in", | ||
| "listings.apply.applicationWillBeAvailableOn": "Application will be available for download and pick up on %{openDate}", | ||
| "listings.apply.applyOnline": "Apply online", | ||
| "listings.apply.applyOnlineMessage": "* This button brings you to an external website where you can create an account and apply for this listing.", |
There was a problem hiding this comment.
I know this is existing language so we should probably keep it. However, accounts aren't required in San Jose so this is kind of misleading.
| <div className="text-gray-800 text-sm"> | ||
| {props.isExternal && | ||
| (props.strings?.applyOnlineMessage ?? t("listings.apply.applyOnlineMessage"))} | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
nit: It's ok to have this here since you already implemented it. But we don't support the non-seeds view anymore so it would have been ok to not implement this
| <>{onlineApplicationUrl ? ApplyOnlineButton : DownloadApplicationButton}</> | ||
| <> | ||
| {onlineApplicationUrl ? ApplyOnlineButton : DownloadApplicationButton} | ||
| {listing.externalURL && t("listings.apply.applyOnlineMessage")} |
There was a problem hiding this comment.
nit: I know there are no designs for this so this might just be a personal opinion. I think there should be a gap between the button and the disclaimer
2 participants
This PR addresses #(6367)
Description
For external listings ingested by the system, they need to be displayed on the listing details page. To do this, the system fetches the live data from the external system. If the listing has a common app, it will reroute the user to the external site to apply.
How Can This Be Tested/Reviewed?
With
Bloomington: Runyarn setupWith
Bridge Bay: Runyarn db:setup:staging-regionSign in as an admin through the partners site or the api
Through the api, call the /externalListings/ingest endpoint with the relevant data (found below)
On the public site, navigate to the listings browse page
Click on a internal listing, confirm listing detail page loads as expected. Click Apply now and confirm start page loads
Return to the listings browse page
Click on a external listing, confirm listing detail page loads as expected. Click Apply now and confirm you are redirected and start page loads
Call the ingest endpoint with the following payload, using the desired jurisdiction id to associate the listings with:
{ "externalURL": "https://hba-0-3-alameda-staging.herokuapp.com/", "jurisdictionId": "{id}", "targetName": "San Jose" }Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: