Skip to content

Close out the 2026-08-24 architecture review #406

Description

@blooop

Destination

Every finding from the 2026-08-24 architecture review is closed: each either landed as a reviewed PR with a test that proves the behaviour was absent, or is recorded as ruled out with the evidence that ruled it out. The one defect already fixed — DEVLAUNCH_NO_TTY read two ways — is merged.

Notes

Source: an architecture review of this repo on 2026-08-24 at v0.13.0 (fix_arch, parent 9392779), run against the deep-module vocabulary — module, interface, depth, seam, adapter, leverage, locality. Findings carry file:line evidence and are restated in each ticket.

Agent-decided, by invocation. This map was handed to wf-auto, so decision tickets are settled against the principles rather than by grilling, and every resolution names the principle that decided it. That is this map's rule and does not travel: the sibling map Close out the 2026-08 architecture review carries an explicit human-in-the-loop steering line, and nothing here re-decides a ticket that lives there.

Overlap with #299, which was found only after these tickets were filed. Two were duplicates and are closed:

Ordering note: the Provision-seam ticket is blocked on #299's Move ColdPath and ToolProvisioning into core, which relocates the very impl it reshapes — so the trait moves once, not twice. That blocker is human-gated on #299, so this map parks rather than reaching past it.

Progress (2026-08-24 run)

Seven pull requests, all merged on 2026-08-25. The run itself ended with every one of them open and in review, which is where an unattended run ends.

PR ticket state
#407 the DEVLAUNCH_NO_TTY fix merged 2026-08-25
#413 #402 merged 2026-08-25
#414 #401 merged 2026-08-25
#415 #409 merged 2026-08-25
#427 #394 merged 2026-08-25
#428 #412 merged 2026-08-25
#429 #399 merged 2026-08-25

Every PR was reviewed by an agent that did not write it. That gate found a
layering violation in #427, a guard with four holes in #415, a silently-dropped
Absent in #428, and a coverage hole plus a false doc claim in #407 — none of
which the authors or the manager caught.

Two things the run learned the hard way, recorded so the next one starts with
them: the build brief named tests, clippy and fmt as the gate and forgot the
CHANGELOG, so six PRs arrived owing one; and agents sharing a working tree means
git add -A will eventually commit somebody else's file, which it did.

Closed 2026-08-28: the four node tickets whose PRs merged, #399, #401, #402 and #409, each with a closing comment citing its PR. Still live on this map: #397, #410, #411, #416, #431, #432.

Parked

Decisions so far

Not yet specified

Out of scope

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions