User-friendly approach for extra configs to run natively on macOS #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperrealist
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a wrapper around start_supervisor.sh that configures the loopback interface on macOS (allowing native installation of the tutorial on macOS). This is an alternative to the approach in #129 where extra instructions were added to the documentation. In contrast, this new approach does the heavy lifting for the user from within the tutorial notebook itself, hiding the unnecessary complexity and allowing for a better user experience.
In #129 @mrakitin suggested a cleanup step should also be included. This wrapper has this capability with
--shutdownargument, but I think it may not be necessary to add it to the notebook since the aliases added to the loopback interface in this patch are not permanent modifications that persist between reboots. Also other notebooks in the tutorial may need the IOCs to be running, so it is not clear where to reference the--shutdownfeature. But as always, I am totally open for suggestions.