Skip to content

Commit

Permalink
[TASK] Limit commit message line length to 72 characters
Browse files Browse the repository at this point in the history
The commit messages line-length is documented as 72 characters. The
commit-msg hook checks for 72 characters now.

Before the hook checked for 74 characters.

Resolves: #103363
Releases: main, 12.4, 11.5
Change-Id: I15138831a73e84f275e85a5cd88f0b33319f9c1c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83406
Tested-by: Benjamin Franzke <[email protected]>
Tested-by: Benni Mack <[email protected]>
Reviewed-by: Benni Mack <[email protected]>
Tested-by: core-ci <[email protected]>
Reviewed-by: Benjamin Franzke <[email protected]>
Reviewed-by: Guido Schmechel <[email protected]>
  • Loading branch information
rr-it authored and bmack committed Mar 11, 2024
1 parent b5e7165 commit 6393ef1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Build/git-hooks/commit-msg
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ ERROR_TEXT="\n"
# Check for maximum line length
#
checkForLineLength() {
if grep -q -E '^[^#].{74}' "$MSG"; then
if grep -q -E '^[^#].{72}' "$MSG"; then
COMMIT_MSG_ERROR_FOUND=1
ERROR_TEXT="${ERROR_TEXT} - The maximum line length of 74 characters is exceeded.\n"
ERROR_TEXT="${ERROR_TEXT} - The maximum line length of 72 characters is exceeded.\n"
fi
}

Expand Down

0 comments on commit 6393ef1

Please sign in to comment.