Skip to content

fix(installer): support Automator source-root installs#2392

Closed
dickymoore wants to merge 1 commit into
bmad-code-org:mainfrom
dickymoore:draft/automator-installable-again
Closed

fix(installer): support Automator source-root installs#2392
dickymoore wants to merge 1 commit into
bmad-code-org:mainfrom
dickymoore:draft/automator-installable-again

Conversation

@dickymoore
Copy link
Copy Markdown
Contributor

@dickymoore dickymoore commented May 18, 2026

Summary

Restores Automator installability on the installer side with a minimal upstream-compatible change set.

Changes

  • teach external module resolution to honor source_root
  • add targeted installer-component coverage for source-root modules and path-escape rejection

Why

Automator's installable module content now lives under a module root directory (skills/) rather than being discovered through a module.yaml entrypoint path. The installer therefore needs to support official modules declared via source_root.

Scope limits

  • does not change stale-module preservation behavior
  • does not add CLI aliases for automator
  • does not redesign registry loading
  • does not change Automator runtime behavior
  • does not reintroduce deleted fallback-registry machinery

Relationship To Other PRs

This PR is part of the pair that restores fresh Automator installability.

It should be merged together with, or immediately after:

  • bmad-plugins-marketplace#26 which updates the live Automator registry entry to source_root: skills

Related but separate:

  • BMAD-METHOD#2391 is the stale-install compatibility fix for existing baut installs

Validation

  • node test/test-installation-components.js
  • full pre-commit suite passed during commit (npm test, lint, markdown lint, format check)`

@dickymoore
Copy link
Copy Markdown
Contributor Author

Cross-linking for review context:

This PR is one half of the fresh-installability fix for Automator.

Paired PR:

  • bmad-plugins-marketplace#26

Why the pair is needed:

  • this PR teaches the installer to consume official modules declared via source_root
  • #26 publishes Automator in the live registry with source_root: skills

Related but separate:

  • BMAD-METHOD#2391 is only the stale-install compatibility fix for existing baut installs

Recommended merge order:

  • merge #26 and this PR together, or #26 first and this PR immediately after

@dickymoore dickymoore force-pushed the draft/automator-installable-again branch from 76baa0e to dd55226 Compare May 18, 2026 10:42
@dickymoore
Copy link
Copy Markdown
Contributor Author

Closing this draft as unnecessary after rechecking current upstream state.

Automator already ships the standard BMAD module metadata on main at skills/module.yaml and skills/module-help.csv, and current upstream BMAD installs baut successfully through the normal module_definition: skills/module.yaml path. That means the source_root installer extension is no longer the right fix.

The remaining structural cleanup is now tracked in:

  • bmad-code-org/bmad-automator#14

That Automator PR keeps BMAD conventional by aligning the module metadata with the existing registry/installer code instead of teaching BMAD a special module shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant