-
Notifications
You must be signed in to change notification settings - Fork 15
Write system tests for lobster-json regarding directory input NEW #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mugdhadhole1
wants to merge
2
commits into
main
Choose a base branch
from
internal/lobster-json-test-directory-recursion-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package json_req | ||
| import req | ||
|
|
||
| req.System_Requirement Parse_Input_File { | ||
| description = ''' | ||
| IF a list element given through the command line option "FILE_OR_DIR" is a file, | ||
|
|
||
| (OTHERWISE, the tool shall exit with a non-zero return code.) | ||
| ''' | ||
| } | ||
|
|
||
| req.System_Requirement_Aspect Parse_Input_File_JSON_Extension { | ||
| description = ''' | ||
| AND if the file extension is "json" (case-insensitive), | ||
| ''' | ||
| } | ||
|
|
||
| req.System_Requirement_Aspect Parse_Input_File_Valid_JSON { | ||
| description = ''' | ||
| AND if the file content is valid JSON, | ||
| ''' | ||
| } | ||
|
|
||
| req.System_Requirement_Aspect Parse_Input_File_Input_Items { | ||
| description = ''' | ||
| THEN each key-value pair of the outer-most dictionary of the JSON data struct | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this really the way it is implemented? |
||
| ''' | ||
| } | ||
|
|
||
| req.System_Requirement_Aspect Parse_Input_File_To_Lobster { | ||
| description = ''' | ||
| SHALL be written in the LOBSTER interchange format | ||
| ''' | ||
| } | ||
|
|
||
| // missing aspect: how to convert (i.e. what is the item name)? | ||
|
|
||
| req.System_Requirement_Aspect Parse_Input_File_To_Stdout { | ||
| description = ''' | ||
| to the file given in the command line option "out", | ||
| IF that option is given and is not an empty string, | ||
| ''' | ||
| } | ||
|
|
||
| req.System_Requirement_Aspect Parse_Input_File_To_File { | ||
| description = ''' | ||
| OTHERWISE to STDOUT. | ||
| ''' | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should become a new requirement