Open
Conversation
TannazVhdBMWExt
force-pushed
the
feature/lobster-pkg-api-function
branch
from
f4ececf to
58a943d
Compare
phiwuu
requested changes
Dec 9, 2025
Member
There was a problem hiding this comment.
The current proposal does the following:
- convert all API arguments from native types (like integer) to strings
- run the lobster-pkt tool, which will parse the strings and convert them to native types (like integer)
In my opinion the lobster-pkg tool should call the API, not the other way around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #513 accidentally deleted the
lobster_pkgapi function from filelobster/tools/pkg/pkg.py, because it became a member function of classPkgTool.