fix: add bsc validation error for new payload#276
Closed
Conversation
- Define BSC_VALIDATION_ERROR_PREFIX constant to replace fragile string matching - Use starts_with() instead of contains() for more precise error identification - Change ImportFut return type to (Option<Outcome>, B256) to carry block hash - Always clean up queued_blocks after import completes, allowing block retry on transient BSC validation errors - Add unit test for BSC validation error skip path Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
#297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#258
Currently, the reth-bsc node occasionally experiences bad blocks, and the cause is a problem with the computing of its own node. This fix means that when there is a problem with the node itself, no penalty will be imposed on the peer. This can prevent all cases where peers are disconnected.