Fix missing '.' in filter name #6455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that PDE is shipping the jar editor I noticed since a while that a folder/project .BndtoolsJAREditorTempFiles is shown, even though there is a filter to hide it. Looking a bit closer it seems to me that while it was renamed three years ago to start with a dot the actual filterExpression was not adjusted (only the description/name) Signed-off-by: Christoph Läubrich <[email protected]>
laeubi
force-pushed
the
fix_typo_in_filter
branch
from
510aed4 to
32a3132
Compare
|
thanks @laeubi Let's very with latest snapshot which should be available in a few minutes after the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that PDE is shipping the jar editor I noticed since a while that a folder/project .BndtoolsJAREditorTempFiles is shown, even though there is a filter to hide it.
Looking a bit closer it seems to me that while it was renamed three years ago to start with a dot the actual filterExpression was not adjusted (only the description/name)