-
-
Notifications
You must be signed in to change notification settings - Fork 476
Implement control flow graph construction #3037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Nice! This'll also be really useful when we eventually implement JIT compilation |
Razican
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great step :) I added a couple of comments, but I didn't do a full review yet
e60cb81 to
f572038
Compare
Test262 conformance changes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3037 +/- ##
==========================================
+ Coverage 48.88% 49.34% +0.46%
==========================================
Files 471 473 +2
Lines 48492 48814 +322
==========================================
+ Hits 23705 24088 +383
+ Misses 24787 24726 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Coincidentally, I found this crate that could simplify the optimizer logic: |
Looks interesting! But I think it would be better to create our own, because JS semantics are complex and it would be easier to extend. I postponed this PR until #3059 is fully complete (currently refactoring generators, which are the remaining test262 failing tests). |
a8cb2b4 to
ca3c13d
Compare
ca3c13d to
106accd
Compare
This PR is a WIP implementation of control flow graph construction from bytecode, that will be used for many optimizations, like dead-code-elimination.
TODO
BasicBlockand redirect it's referencesBasicBlockand redirect it's references