Fix Renderer errors with --enable-frozen-string-literal#244
Open
anthonykaufman wants to merge 1 commit into
Open
Fix Renderer errors with --enable-frozen-string-literal#244anthonykaufman wants to merge 1 commit into
anthonykaufman wants to merge 1 commit into
Conversation
Owner
|
Hi, I'm sorry I missed this. Did the 1.0.29 version fix this issue, or do I still need to fix and merge? Thanks. |
There were several instances in which adding .b to string literals was necessary to not throw this error when --enable-frozen-string-literal was enabled. Exposed with tests.
70e51ab to
a30667c
Compare
Author
|
No worries! I rebased on master and without the changes I made to |
|
@anthonykaufman any news on this PR? I could really use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were several instances in which adding .b to string literals was necessary to not throw this error when --enable-frozen-string-literal was enabled.
To reproduce I used Ruby 2.7.8 with the
--enable-frozen-string-literaloption enabled:You should get 3 test errors.