Add fast decode_lossy path for incomplete codepages #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds benchmark for decode_lossy with mostly ASCII input (90% ASCII, 10% extended) to measure performance on typical mixed-content data.
Use dual-table approach for incomplete codepages: - DECODE_TABLE: Option<UTF8Entry> with UTF8Len enum (niche-optimized) - DECODE_TABLE_LOSSY: CompleteEntry with branchless 4-byte writes decode_lossy uses the pre-filled lossy table with the fast complete decoder, achieving 1.5-2x speedup with no regression to decode_checked.
- Move CompleteEntry to decoder/complete.rs as Entry - Move UTF8Entry/UTF8Len to decoder/incomplete.rs as Entry/Len - Re-export with descriptive names: CompleteEntry, IncompleteEntry, IncompleteLen - Update codegen to use new naming convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DECODE_TABLE(withOption<Entry>) for checked decoding, andDECODE_TABLE_LOSSY(pre-filled with replacement chars) for lossy decodingdecode_lossynow uses the pre-filled table with the fast branchless 4-byte write path from complete decodersBenchmark Results
decode_lossy/all_bad/4096decode_lossy/all_bad/2048decode_lossy/all_bad/1024decode_lossy/mostly_ascii/4096decode_lossy/mostly_ascii/2048decode_lossy/mostly_ascii/1024No regression to
decode_checkedperformance.Test plan