perf: optimize decode_checked for extended characters #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make Entry::write() branchless by always copying 3 bytes - Add ASCII fast path in decode_slice to skip table lookup for ASCII bytes - Use const generic to unify decode_slice variants This fixes a regression in decode_checked/extended (was 25-30% slower than v0.2.0) while improving decode_checked/mostly_ascii by 10-24% over v0.2.0. Benchmarks vs v0.2.0: - decode_checked/extended: now equal (was 25-30% slower) - decode_checked/mostly_ascii: 10-24% faster - decode_checked/ascii: equal - decode_lossy/*: 1.7-2.3x faster (unchanged) - encode_*: 2x+ faster (unchanged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Entry::writebranchless by always copying 3 bytes, then advancing by actual lengthdecode_slice_innerusing const generic to skip table lookups for ASCII bytesdecode_slicevariants withconst ASCII_OPT: boolgeneric parameterBenchmark Results (vs master)
decode_checked/extended (primary target):
decode_checked/mostly_ascii:
Test plan