Add setting for menu location

inc/class-helpers.php

@@ -1226,6 +1226,38 @@ public static function setting_show_as_menu_page() {
 		return (bool) $setting;
 	}
 
+	/**
+	 * Returns the location of the main simple history menu page.
+	 * Valid locations are:
+	 * - 'top' = Below dashboard and Jetpack and similar top level menu items.
+	 * - 'bottom' = Below settings and similar bottom level menu items.
+	 *
+	 * Defaults to 'top'.
+	 *
+	 * @return string Location of the main menu page.
+	 */
+	public static function setting_menu_page_location() {
+		$option_slug = 'simple_history_menu_page_location';
+		$setting = get_option( $option_slug );
+
+		// If it does not exist, then default so the option can auto-load.
+		if ( false === $setting ) {
+			$setting = 'top';
+			update_option( $option_slug, $setting, true );
+		}
+
+		/**
+		 * Filter to control the placement of Simple History in the Admin Menu.
+		 *
+		 * @since 5.5.2
+		 *
+		 * @param string $setting Either 'top' for placement below dashboard or 'bottom' for placement below settings.
+		 */
+		$setting = apply_filters( 'simple_history/admin_menu_location', $setting );
+
+		return $setting;
+	}
+
 	/**
 	 * Returns true if Simple History can be shown in the admin bar
 	 *

inc/services/class-admin-pages.php

@@ -41,6 +41,18 @@ public function add_main_admin_pages() {
 			return;
 		}
 
+		$admin_page_location = Helpers::setting_menu_page_location();
+		$admin_page_position = '';
+		switch ( $admin_page_location ) {
+			case 'bottom':
+				$admin_page_position = 80;
+				break;
+			case 'top':
+			default:
+				$admin_page_position = 3.5;
+				break;
+		}
+
 		// Add History page as a main menu item, at the root.
 		// For example Jetpack adds itself at prio 3. We add it at prio 3.5 to be below Jetpack but above posts.
 		add_menu_page(
@@ -52,7 +64,7 @@ public function add_main_admin_pages() {
 			// Logo SVG image is same as in AdminBarQuickView.scss.
 			// Source is 'simple-history-wp-admin-bar-icon-20x20-no-clippath.svg'.
 			'data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjAiIGhlaWdodD0iMjAiIHZpZXdCb3g9Ii0yIC0yIDI0IDI0IiBmaWxsPSJub25lIgogICAgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KICAgIDxwYXRoIGQ9Ik0xNC4wNjI3IDAuNzc3NTg2QzkuMjM5MDQgLTEuMjkyNTMgMy43Njk2MiAwLjk1MzcxMSAxLjkxNzEzIDUuMzQ4NjNMMC4zOTEyNCA0LjY5Mzc3QzAuMTY5MDA3IDQuNTk4NCAtMC4wNTg3NTI3IDQuODE2ODcgMC4wMTM3MTIyIDUuMDU1OUwwLjg1MzU3MyA5Ljc3ODU2QzAuOTM1MjQ1IDEwLjA0OCAxLjIzNDM4IDEwLjE3MDEgMS40Njk0MSAxMC4wM0w1LjAzOTQ0IDcuMjA0MTdDNS4yNDQwMyA3LjA4MjIxIDUuMjI0NDQgNi43NjggNS4wMDY0MiA2LjY3NDQzTDMuMzcwODIgNS45NzI0OUM0Ljg5MzM2IDIuNDE0ODQgOS40NDQ4NiAwLjU2ODMgMTMuNDY1NyAyLjI5Mzg4QzE3LjQ4NjUgNC4wMTk0NiAxOS41MDQ2IDguOTI0OTMgMTcuODI2NCAxMy4xODc1QzE2LjE0ODIgMTcuNDUwMSAxMS40NzQ5IDE5LjQ4MzggNy4zODgzMSAxNy43M0M1LjYxNzMxIDE2Ljk3IDQuMjQ3NDUgMTUuNjIzMSAzLjM5OTggMTMuOTk0MUMzLjE5NDA5IDEzLjU5ODcgMi43NDEzMSAxMy40MDIgMi4zNDM0MiAxMy41NzUxQzEuOTQwNDggMTMuNzUwNSAxLjc0NzgxIDE0LjIzNzUgMS45NTAyNCAxNC42NDEyQzIuOTU4MDkgMTYuNjUxIDQuNjIzNDkgMTguMzE2IDYuNzkxMzMgMTkuMjQ2M0MxMS42ODA3IDIxLjM0NDcgMTcuMjcyMiAxOC45MTEzIDE5LjI4IDEzLjgxMTRDMjEuMjg3OSA4LjcxMTQyIDE4Ljk1MiAyLjg3NTkxIDE0LjA2MjcgMC43Nzc1ODZaIiBmaWxsPSJibGFjayIvPgogICAgPHBhdGggZmlsbC1ydWxlPSJldmVub2RkIiBjbGlwLXJ1bGU9ImV2ZW5vZGQiIGQ9Ik05LjI5ODA4IDYuMTcwNzZDOS4yOTgwOCA1Ljc3MzA3IDkuNTk5NTkgNS40NTA2OCA5Ljk3MTUxIDUuNDUwNjhDMTAuMzQzNCA1LjQ1MDY4IDEwLjY0NDkgNS43NzMwNyAxMC42NDQ5IDYuMTcwNzZWMTAuNTIyOUwxMy42ODY3IDEyLjUwMzZDMTQuMDAzNyAxMi43MTAxIDE0LjEwMDggMTMuMTU0NCAxMy45MDIyIDEzLjQ4OTdDMTMuNzA4NCAxMy44MTY4IDEzLjMwNTMgMTMuOTE3NSAxMi45OTYxIDEzLjcxNjFMOS4yOTgwOCAxMS4zMDgxVjYuMTcwNzZaIiBmaWxsPSJibGFjayIvPgo8L3N2Zz4K',
-			'3.5'
+			$admin_page_position
 			// 3.5 = Below dashboard and jetpack
 			// 5 = Below posts.
 			// 60 = Appearance

inc/services/class-setup-settings-page.php

@@ -147,6 +147,7 @@ public function add_settings() {
 			)
 		);
 
+		// Setting for showing in admin bar.
 		register_setting(
 			$settings_general_option_group,
 			'simple_history_show_in_admin_bar',
@@ -158,6 +159,16 @@ public function add_settings() {
 			)
 		);
 
+		// Setting for menu page location.
+		register_setting(
+			$settings_general_option_group,
+			'simple_history_menu_page_location',
+			array(
+				'sanitize_callback' => 'sanitize_text_field',
+			)
+		);
+
+		// Output for where to show history, in dashboard, admin bar.
 		add_settings_field(
 			'simple_history_show_where',
 			Helpers::get_settings_field_title_output( __( 'Show history', 'simple-history' ), 'visibility' ),
@@ -173,7 +184,8 @@ public function add_settings() {
 			$settings_menu_slug,
 			$settings_section_general_id
 		);
-		// Number if items to show on the history page.
+
+		// Output for number if items to show on the history page.
 		add_settings_field(
 			'simple_history_number_of_items',
 			Helpers::get_settings_field_title_output( __( 'Items per page', 'simple-history' ), 'filter_list' ),
@@ -215,34 +227,36 @@ public function settings_section_output() {
 	 * Settings field output for menu page location
 	 */
 	public function settings_field_menu_page_location() {
-		$show_as_menu_page = Helpers::setting_show_as_menu_page();
+		$location = Helpers::setting_menu_page_location();
+		$option_slug = 'simple_history_menu_page_location';
 		?>
 
 		<fieldset>
 			<label>
 				<input 
-					type="radio" 
-					name="menu_location" 
-					value="Top of menu" 
-					<?php // checked( $days_to_keep_log_type === 'keep_forever' ); ?> 
+					type="radio"
+					name="<?php echo esc_attr( $option_slug ); ?>"
+					value="top"
+					<?php checked( $location === 'top' ); ?>
 				/>
-				At top (below Dashboard)
+				<?php esc_html_e( 'Top of menu', 'simple-history' ); ?>
 			</label>
 
 			<br />
 
 			<label>
 				<input 
-					type="radio" 
-					name="menu_location" 
-					value="Bottom of menu" 
-					<?php // checked( $days_to_keep_log_type === 'keep_forever' ); ?> 
+					type="radio"
+					name="<?php echo esc_attr( $option_slug ); ?>"
+					value="bottom"
+					<?php checked( $location === 'bottom' ); ?>
 				/>
-				At bottom (below Settings)
+				<?php esc_html_e( 'Bottom of menu', 'simple-history' ); ?>
 			</label>
 		</fieldset>
 		<?php
 	}
+
 	/**
 	 * Settings field for where to show the log, page or dashboard
 	 */

readme.txt

@@ -282,6 +282,7 @@ Read more at the [FAQ on the plugin website](https://simple-history.com/docs/faq
 
 -   Add filter `simple_history/show_admin_menu_page`.
 -   Add filter `simple_history/show_in_admin_bar`.
+-   Add filter `simple_history/admin_menu_location`.
 -   Decrease the icon size in the admin bar and main menu, to match the size of other icons. Props @hjalle.
 -   Add helper function `setting_show_as_menu_page()`.