[FIX/#177]사진 전달되는 순서 정렬해서 보내기 #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- viewPosition에 따라 적당한 순서로 이미지 배열을 정렬해서 보냅니다. - PositionOrder는 참가자순서로 나열된 ViewPosition을 배열에 담길 순서로 바꿔줍니다 - userInfo가 nil일 경우 PositionOder의 sequence를 2로 처리합니다.(배열의 2번 인덱스가 마지막 자리)
- localImage nil일 경우 빈 UIImage 전달하도록 변경 - UserInfo를 보내는 곳에 ViewPosition만 전달
Open
1 task
Kiyoung-Kim-57
changed the base branch from
develop
to
fix/#175-hotfix-for-demo
0Hooni
approved these changes
Dec 3, 2024
...r/DomainLayer/PhotoGetherDomain/PhotoGetherDomain/UseCaseImpl/CaptureVideosUseCaseImpl.swift
Outdated
Show resolved
Hide resolved
Comment on lines
-9
to
-12
| PTGImage.temp1.image, | ||
| PTGImage.temp2.image, | ||
| PTGImage.temp3.image, | ||
| PTGImage.temp4.image] |
Collaborator
There was a problem hiding this comment.
디자인 시스템 의존성이 있을텐데 지워주시면 좋을것 같습니다 👍
Co-authored-by: YeongHoon Song <[email protected]>
- 사진 촬영 때 카메라 링 하이라이트
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
📃 작업 내역
✅ 리뷰 노트
🎨 스크린샷
🚀 테스트 방법