Fix warnings so library runs under -Wextra -Werror

include/boost/numeric/odeint/algebra/algebra_dispatcher.hpp

@@ -22,6 +22,21 @@
 #include <complex>
 #include <boost/type_traits/is_floating_point.hpp>
 
+#if defined(__clang__) && __clang_major__ >= 13 && !defined(__APPLE__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy-with-user-provided-copy"
+#elif defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy"
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-copy"
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#elif defined(_MSC_VER)
+#pragma warning(push)
+#pragma warning(disable : 5267)
+#endif
+
 #include <boost/numeric/ublas/vector.hpp>
 #include <boost/numeric/ublas/matrix.hpp>
 
@@ -104,6 +119,15 @@ struct algebra_dispatcher< std::array< T , N > >
 
 } } }
 
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic pop
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic pop
+#elif defined(_MSC_VER)
+#pragma warning(pop)
+#endif
+
+
 #endif
 
 

include/boost/numeric/odeint/algebra/detail/for_each.hpp

@@ -23,6 +23,10 @@ namespace numeric {
 namespace odeint {
 namespace detail {
 
+#if defined(__GNUC__) && __GNUC__ >= 7
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wuninitialized"
+#endif
 
     template< class Iterator1 , class Operation >
     inline void for_each1( Iterator1 first1 , Iterator1 last1 , Operation op )
@@ -155,6 +159,9 @@ namespace detail {
             op( *first1++ , *first2++ , *first3++ , *first4++ , *first5++ , *first6++ , *first7++ , *first8++ , *first9++ , *first10++ , *first11++ , *first12++ , *first13++ , *first14++ , *first15++ );
     }
 
+#if defined(__GNUC__) && __GNUC__ >= 7
+#pragma GCC diagnostic pop
+#endif
 
 } // detail
 } // odeint

include/boost/numeric/odeint/algebra/multi_array_algebra.hpp

@@ -18,6 +18,23 @@
 #ifndef BOOST_NUMERIC_ODEINT_ALGEBRA_MULTI_ARRAY_ALGEBRA_HPP_DEFINED
 #define BOOST_NUMERIC_ODEINT_ALGEBRA_MULTI_ARRAY_ALGEBRA_HPP_DEFINED
 
+#if defined(__clang__) && __clang_major__ >= 13 && !defined(__APPLE__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy-with-user-provided-copy"
+#elif defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy"
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-copy"
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+#elif defined(__GNUC__) && __GNUC__ >= 5
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+#elif defined(_MSC_VER)
+#pragma warning(push)
+#pragma warning(disable : 5267)
+#endif
 
 #include <boost/multi_array.hpp>
 
@@ -142,5 +159,12 @@ struct algebra_dispatcher< boost::multi_array< T , N > >
 } // namespace numeric
 } // namespace boost
 
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic pop
+#elif defined(__GNUC__) && __GNUC__ >= 5
+#pragma GCC diagnostic pop
+#elif defined(_MSC_VER)
+#pragma warning(pop)
+#endif
 
 #endif // BOOST_NUMERIC_ODEINT_ALGEBRA_MULTI_ARRAY_ALGEBRA_HPP_DEFINED

include/boost/numeric/odeint/stepper/adams_bashforth_moulton.hpp

@@ -19,6 +19,20 @@
 #ifndef BOOST_NUMERIC_ODEINT_STEPPER_ADAMS_BASHFORTH_MOULTON_HPP_INCLUDED
 #define BOOST_NUMERIC_ODEINT_STEPPER_ADAMS_BASHFORTH_MOULTON_HPP_INCLUDED
 
+// Need this PR to be merged to actually fix the issue: https://github.com/boostorg/ublas/pull/153
+#if defined(__clang__) && __clang_major__ >= 13 && !defined(__APPLE__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy-with-user-provided-copy"
+#elif defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy"
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-copy"
+#elif defined(_MSC_VER)
+#pragma warning(push)
+#pragma warning(disable : 5267)
+#endif
 
 #include <boost/numeric/odeint/util/bind.hpp>
 
@@ -309,6 +323,12 @@ public :
 } // numeric
 } // boost
 
-
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic pop
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic pop
+#elif defined(_MSC_VER)
+#pragma warning(pop)
+#endif
 
 #endif // BOOST_NUMERIC_ODEINT_STEPPER_ADAMS_BASHFORTH_MOULTON_HPP_INCLUDED

include/boost/numeric/odeint/stepper/bulirsch_stoer.hpp

@@ -88,6 +88,18 @@ class bulirsch_stoer {
 #endif //DOXYGEN_SKIP
     const static size_t m_k_max = 8;
 
+// Claims m_error_checker will be init after m_max_dt
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wreorder-ctor"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wreorder"
+#elif defined(_MSC_VER)
+#pragma warning(push)
+#pragma warning(disable : 5038)
+#endif
+
     bulirsch_stoer(
         value_type eps_abs = 1E-6 , value_type eps_rel = 1E-6 ,
         value_type factor_x = 1.0 , value_type factor_dxdt = 1.0 ,
@@ -123,6 +135,13 @@ class bulirsch_stoer {
         reset();
     }
 
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#elif defined(_MSC_VER)
+#pragma warning(pop)
+#endif
 
     /*
      * Version 1 : try_step( sys , x , t , dt )

include/boost/numeric/odeint/stepper/bulirsch_stoer_dense_out.hpp

@@ -95,6 +95,17 @@ class bulirsch_stoer_dense_out {
     const static size_t m_k_max = 8;
 
 
+// Claims m_error_checker will be init after m_max_dt
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wreorder-ctor"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wreorder"
+#elif defined(_MSC_VER)
+#pragma warning(push)
+#pragma warning(disable : 5038)
+#endif
 
     bulirsch_stoer_dense_out(
         value_type eps_abs = 1E-6 , value_type eps_rel = 1E-6 ,
@@ -838,4 +849,12 @@ class bulirsch_stoer_dense_out {
 }
 }
 
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#elif defined(_MSC_VER)
+#pragma warning(pop)
+#endif
+
 #endif // BOOST_NUMERIC_ODEINT_STEPPER_BULIRSCH_STOER_HPP_INCLUDED

include/boost/numeric/odeint/stepper/explicit_error_generic_rk.hpp

@@ -164,8 +164,8 @@ class explicit_error_generic_rk : public explicit_error_stepper_base
 
     resizer_type m_resizer;
 
-    wrapped_state_type m_x_tmp;
-    wrapped_deriv_type m_F[StageCount-1];
+    wrapped_state_type m_x_tmp {};
+    wrapped_deriv_type m_F[StageCount-1] {};
 
 };
 

include/boost/numeric/odeint/stepper/explicit_generic_rk.hpp

@@ -78,6 +78,10 @@ struct stage_wrapper
 };
 #endif
 
+#if defined(__GNUC__) && __GNUC__ >= 7
+#  pragma GCC diagnostic push
+#  pragma GCC diagnostic ignored "-Wuninitialized"
+#endif
 
 template<
 size_t StageCount,
@@ -183,7 +187,9 @@ class explicit_generic_rk : public explicit_stepper_base
 
 };
 
-
+#if defined(__GNUC__) && __GNUC__ >= 7
+#  pragma GCC diagnostic pop
+#endif
 
 /*********** DOXYGEN *************/
 

include/boost/numeric/odeint/stepper/generation/generation_controlled_adams_bashforth_moulton.hpp

@@ -40,13 +40,13 @@ struct controller_factory< Stepper , controlled_adams_bashforth_moulton< Stepper
     typedef typename stepper_type::value_type value_type;
     typedef typename stepper_type::value_type time_type;
 
-    controller_type operator()( value_type abs_error , value_type rel_error , const stepper_type &stepper )
+    controller_type operator()( value_type abs_error , value_type rel_error , const stepper_type &/*stepper*/ )
     {
         return controller_type(step_adjuster_type(abs_error, rel_error));
     }
 
     controller_type operator()( value_type abs_error , value_type rel_error ,
-                                time_type max_dt, const stepper_type &stepper )
+                                time_type max_dt, const stepper_type &/*stepper*/ )
     {
         return controller_type( step_adjuster_type(abs_error, rel_error, max_dt));
     }

include/boost/numeric/odeint/stepper/implicit_euler.hpp

@@ -19,6 +19,20 @@
 #ifndef BOOST_NUMERIC_ODEINT_STEPPER_IMPLICIT_EULER_HPP_INCLUDED
 #define BOOST_NUMERIC_ODEINT_STEPPER_IMPLICIT_EULER_HPP_INCLUDED
 
+#if defined(__clang__) && __clang_major__ >= 13 && !defined(__APPLE__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy-with-user-provided-copy"
+#elif defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy"
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-copy"
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#elif defined(_MSC_VER)
+#pragma warning(push)
+#pragma warning(disable : 5267)
+#endif
 
 #include <utility>
 
@@ -166,5 +180,12 @@ class implicit_euler
 } // numeric
 } // boost
 
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic pop
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic pop
+#elif defined(_MSC_VER)
+#pragma warning(pop)
+#endif
 
 #endif // BOOST_NUMERIC_ODEINT_STEPPER_IMPLICIT_EULER_HPP_INCLUDED

include/boost/numeric/odeint/stepper/rosenbrock4.hpp

@@ -20,6 +20,21 @@
 #ifndef BOOST_NUMERIC_ODEINT_STEPPER_ROSENBROCK4_HPP_INCLUDED
 #define BOOST_NUMERIC_ODEINT_STEPPER_ROSENBROCK4_HPP_INCLUDED
 
+// Need this PR to be merged to actually fix the issue: https://github.com/boostorg/ublas/pull/153
+#if defined(__clang__) && __clang_major__ >= 13 && !defined(__APPLE__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy-with-user-provided-copy"
+#elif defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy"
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-copy"
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#elif defined(_MSC_VER)
+#pragma warning(push)
+#pragma warning(disable : 5267)
+#endif
 
 #include <boost/numeric/odeint/util/bind.hpp>
 #include <boost/numeric/odeint/util/unwrap_reference.hpp>
@@ -343,4 +358,13 @@ class rosenbrock4
 } // namespace numeric
 } // namespace boost
 
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic pop
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic pop
+#elif defined(_MSC_VER)
+#pragma warning(pop)
+#endif
+
+
 #endif // BOOST_NUMERIC_ODEINT_STEPPER_ROSENBROCK4_HPP_INCLUDED

include/boost/numeric/odeint/util/detail/less_with_sign.hpp

@@ -26,6 +26,11 @@ namespace numeric {
 namespace odeint {
 namespace detail {
 
+#if defined(__GNUC__) && __GNUC__ >= 5
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+#endif
+
 /**
  * return t1 < t2 if dt > 0 and t1 > t2 if dt < 0 with epsilon accuracy
  */
@@ -73,6 +78,11 @@ T max_abs( T t1 , T t2 )
     else
         return min BOOST_PREVENT_MACRO_SUBSTITUTION ( t1 , t2 );
 }
+
+#if defined(__GNUC__) && __GNUC__ >= 5
+#pragma GCC diagnostic pop
+#endif
+
 } } } }
 
 #endif

include/boost/numeric/odeint/util/ublas_wrapper.hpp

@@ -18,6 +18,21 @@
 #ifndef BOOST_NUMERIC_ODEINT_UTIL_UBLAS_WRAPPER_HPP_INCLUDED
 #define BOOST_NUMERIC_ODEINT_UTIL_UBLAS_WRAPPER_HPP_INCLUDED
 
+// Need this PR to be merged to actually fix the issue: https://github.com/boostorg/ublas/pull/153
+#if defined(__clang__) && __clang_major__ >= 13 && !defined(__APPLE__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy-with-user-provided-copy"
+#elif defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-copy"
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-copy"
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#elif defined(_MSC_VER)
+#pragma warning(push)
+#pragma warning(disable : 5267)
+#endif
 
 #include <boost/type_traits/integral_constant.hpp>
 #include <boost/numeric/ublas/vector.hpp>
@@ -293,5 +308,12 @@ struct state_wrapper< boost::numeric::ublas::permutation_matrix< T , A > > // wi
 
 } } }
 
+#if defined(__clang__) && __clang_major__ >= 10
+#pragma clang diagnostic pop
+#elif defined(__GNUC__) && __GNUC__ >= 9
+#pragma GCC diagnostic pop
+#elif defined(_MSC_VER)
+#pragma warning(pop)
+#endif
 
 #endif // BOOST_NUMERIC_ODEINT_UTIL_UBLAS_WRAPPER_HPP_INCLUDED