-
Notifications
You must be signed in to change notification settings - Fork 101
Specialize range_const_iterator_helper for std::span #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
std::span does not have const_iterator member type, so this fails: #include <span> #include <boost/range/iterator.hpp> using X = boost::range_iterator<std::span<int, 3> const>::type;
FYI: it was caused by http://wg21.link/lwg3320 resolution and a subject of P2276. |
any update on this? |
I think we need to fix up the CI for testing this i.e. Appveyor and Github Actions (Travis is dead to us now). On top of that, this PR will need unit tests. |
iterator<span const> == iterator<span>
Thanks, yeah this is tricky - and also I've taken the approach that we want the simplest possible solution that could work, which for now is ignoring |
std::span does not have const_iterator member type, so this fails:
also
boost::begin()
andboost::end()
fail, and anything that calls them (e.g.boost::size()
).Demo.
I'm using 201902 as the feature test value on the basis that an implementation may have removed
const_iterator
(fixing LWG 3320) but not yet applied P1976R2 which updates the feature test to 202002L.