prefer auto to Rng::(const_)?iterator for generic String #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanghan02
force-pushed
the
thinkcell_prefer_auto_to_iterator
branch
from
e9c7e0f to
4feef89
Compare
wanghan02
changed the title
wanghan02
force-pushed
the
thinkcell_prefer_auto_to_iterator
branch
from
4feef89 to
2389443
Compare
wanghan02
changed the title
wanghan02
force-pushed
the
thinkcell_prefer_auto_to_iterator
branch
from
2389443 to
0bd5492
Compare
1. c++20 ranges library does not require a range to have member type/alias iterator/const_iterator. 2. boost range library uses typename boost::range_iterator<Rng>::type instead of Rng::iterator because a customized Rng may not have member type/alias iterator/const_iterator. e.g. std::pair<It, It>.
wanghan02
force-pushed
the
thinkcell_prefer_auto_to_iterator
branch
from
0bd5492 to
1a09a54
Compare
|
The changes in this commit are all in x3 folder with std14 at least. Somehow CI fails in some std03/11 karma/qi builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typename boost::range_iterator<Rng>::typeinstead ofRng::iteratorbecause a customized Rng may not have member type/alias iterator/const_iterator. e.g.std::pair<It, It>.Therefore for generic String type,
autois better thanRng::(const_)?iterator.