Merge added dimensions and units #19
Conversation
|
|
||
| typedef unit<specific_gas_constant_dimension,si::system> specific_gas_constant; | ||
|
|
||
| BOOST_UNITS_STATIC_CONSTANT(joule_per_kilogram_kelvins, specific_gas_constant); |
There was a problem hiding this comment.
Maybe you should add singular version of kelvins as well? I.e. joule_per_kilogram_kelvin and 3 other variants.
There was a problem hiding this comment.
Certainly, if I have a need for it, I will patch it. Other's contributions are also welcomed.
There was a problem hiding this comment.
It's not a question of one's need, but of consistency...
There was a problem hiding this comment.
The harder question is how to persuade the units system to accept a true energy (Joules) per mass (kilogram) temperature (kelvins). The closest I could come up with was to "manually" reduce the dimensions, which will work when you involve the quantity calculations, but does not appear to be technically correct, according to the Specific Gas Constant docs I was reading. I don't have any ready answers where that's concerned. Can you help with those bits?
|
And what about tests? |
|
Won't merge without tests. And please make a pull request against develop, not master. Thanks. |
See fork issues #1, #2, and #3. Definitely interested in some feedback on how to better approach number two. Could forego number three provided there was a better approach. Thanks and let me know how the merge went.