Skip to content

[BOT] Bump Velox version#612

Merged
zhztheplayer merged 3 commits intomainfrom
bump-velox-434
Apr 14, 2026
Merged

[BOT] Bump Velox version#612
zhztheplayer merged 3 commits intomainfrom
bump-velox-434

Conversation

@velox4j-bot
Copy link
Copy Markdown
Contributor

@velox4j-bot velox4j-bot bot commented Apr 14, 2026

Update Velox to latest. Diff: facebookincubator/velox@948e7be...e6afa63

@velox4j-bot velox4j-bot bot enabled auto-merge (squash) April 14, 2026 06:00
@zhztheplayer
Copy link
Copy Markdown
Contributor

@copilot check ci

auto-merge was automatically disabled April 14, 2026 07:43

Head branch was pushed to by a user without write access

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@copilot check ci

The CI failure was caused by the new Velox version adding a nullAsValue field to HashJoinNode serialization. Fixed in 759b9ca by adding the nullAsValue field to HashJoinNode.java (field, constructor, @JsonCreator, and getter) and updating all test call sites.

@zhztheplayer zhztheplayer enabled auto-merge (squash) April 14, 2026 08:15
@zhztheplayer
Copy link
Copy Markdown
Contributor

@copilot check ci

…w tests

Co-authored-by: zhztheplayer <11284395+zhztheplayer@users.noreply.github.com>
auto-merge was automatically disabled April 14, 2026 09:09

Head branch was pushed to by a user without write access

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@copilot check ci

The CI failure was a compilation error — main had merged a new commit (0eaedd5) that added more HashJoinNode test cases using the old 10-param constructor, but our HashJoinNode now requires 11 params (with nullAsValue). Fixed in b9f1cbc by merging main and adding the nullAsValue parameter to the two new HashJoinNode calls in PlanNodeToStringTest.java.

Copilot AI requested a review from zhztheplayer April 14, 2026 09:10
@zhztheplayer zhztheplayer enabled auto-merge (squash) April 14, 2026 12:49
@zhztheplayer zhztheplayer merged commit 09c569e into main Apr 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants