Skip to content

Fix worker label - #35

Merged
alicefr merged 1 commit into
mainfrom
fix-worker-label
May 28, 2026
Merged

Fix worker label#35
alicefr merged 1 commit into
mainfrom
fix-worker-label

Conversation

@alicefr

@alicefr alicefr commented May 28, 2026

Copy link
Copy Markdown
Collaborator

The correct label for workers is node-role.kubernetes.io/worker="" not node-role.kubernetes.io/worker="worker"

Summary by Sourcery

Bug Fixes:

  • Fix worker node labeling by setting node-role.kubernetes.io/worker to an empty string instead of "worker" when joining non-control-plane nodes.

The correct label for workers is node-role.kubernetes.io/worker="" not
node-role.kubernetes.io/worker="worker"

Signed-off-by: Alice Frosi <afrosi@redhat.com>
@sourcery-ai

sourcery-ai Bot commented May 28, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the worker node Kubernetes label applied during cluster join so it matches the standard empty-string value expected by Kubernetes and related tooling.

Flow diagram for applying correct Kubernetes worker label during cluster join

flowchart TD
    A[Cluster.Join called] --> B{opts.IsControlPlane}
    B -- true --> C[Do not set worker label]
    B -- false --> D[Set labels for node-role.kubernetes.io/worker = ""]
    D --> E[Apply labels to node]
    C --> E
Loading

File-Level Changes

Change Details Files
Set the Kubernetes worker node role label value to an empty string instead of "worker" when joining non-control-plane nodes.
  • Change the value assigned to the node-role.kubernetes.io/worker label for non-control-plane joins from "worker" to an empty string
  • Preserve existing behavior of merging user-provided labels before applying the worker role label
internal/cluster/join.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@alicefr
alicefr merged commit 5fb39c5 into main May 28, 2026
6 of 8 checks passed
@alicefr
alicefr deleted the fix-worker-label branch June 18, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant