Add insertion points for plugins#23
Open
gregschlom wants to merge 2 commits into
Open
Conversation
|
I've integrated this feature into the fork I'm maintaining. Did you find any need for other insertion points ? |
Packetdancer
pushed a commit
to Packetdancer/protobuf-objc
that referenced
this pull request
Feb 4, 2015
Packetdancer
pushed a commit
to Packetdancer/protobuf-objc
that referenced
this pull request
Feb 4, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds two insertion points for plugins:
imports: #import directivesglobal_scope: Declarations that belong at the top level. Appears at the very end of the file.Each insertion point appears in both the .pb.m file and the .pb.h.
I could have added other insertion points inside classes, but I do not need that feature for the moment, so I'd rather avoid coding something blindly.
As a comparison, here are the insertion points generated by the C++ protobuf compiler.