Enhancement signals: small cleanups and tests #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot use both positional and keyword arguments... Signed-off-by: Yves Bastide <[email protected]>
Two tests:
* one where a signal is sent once (normal case)
* one where the signal is sent twice (because it's not waited on). Don't
count on this behavior!
Signed-off-by: Yves Bastide <[email protected]>
This should prevent them from being resent during a specific replay. We'll have to check if this is what causes signals duplication in our workflows... Signed-off-by: Yves Bastide <[email protected]>
Understood 😛 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.