All the changes from Shahlo's copy of FAST and some of mine too #8
+16,442
−1,075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e crystal structures
Pandapip1
changed the title
Contributor
There was a problem hiding this comment.
More a comment than any action - I wonder if there might be a benefit of migrating this functionality to https://github.com/facebookincubator/submitit
Author
There was a problem hiding this comment.
Almost certainly; but I'm not volunteering to do that anytime soon :)
Pandapip1
force-pushed
the
upstream-changes
branch
3 times, most recently
from
bb014ab to
eb766d2
Compare
Significant and breaking changes are made, but the code is a lot cleaner now
Pandapip1
force-pushed
the
upstream-changes
branch
4 times, most recently
from
40f672b to
59102b4
Compare
Pandapip1
force-pushed
the
upstream-changes
branch
4 times, most recently
from
ba9a895 to
2cb0fd4
Compare
Pandapip1
force-pushed
the
upstream-changes
branch
from
cfbd2fa to
8c22321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.