Skip to content

fix(jailer): bind /etc/resolv.conf so allow_net DNS works under the sandbox #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DorianZheng merged 2 commits into from
Jun 25, 2026
Merged

fix(jailer): bind /etc/resolv.conf so allow_net DNS works under the sandbox #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
942dde4
fix(jailer): bind /etc/resolv.conf into the bwrap sandbox for allow_n…
G4614 Jun 25, 2026
2dadbe1
test(cli): drop whoami_updates_stale_profile_path_prefix
G4614 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/boxlite/src/jailer/sandbox/bwrap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,16 @@ impl Sandbox for BwrapSandbox {
.ro_bind_if_exists("/lib", "/lib")
.ro_bind_if_exists("/lib64", "/lib64")
.ro_bind_if_exists("/bin", "/bin")
.ro_bind_if_exists("/sbin", "/sbin");
.ro_bind_if_exists("/sbin", "/sbin")
// DNS resolver config: gvproxy resolves `allow_net` hostnames
// host-side (it runs in this shim) via the Go resolver, which reads
// these. Without them the sandbox has no /etc/resolv.conf, every
// lookup in buildAllowNetDNSZones fails, and allow-listed hosts
// sinkhole to 0.0.0.0 — the allowlist silently blocks everything
// whenever the jailer is enabled (#645).
.ro_bind_if_exists("/etc/resolv.conf", "/etc/resolv.conf")
.ro_bind_if_exists("/etc/hosts", "/etc/hosts")
.ro_bind_if_exists("/etc/nsswitch.conf", "/etc/nsswitch.conf");

// =====================================================================
// Devices and special mounts
Expand Down
45 changes: 0 additions & 45 deletions src/cli/tests/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,51 +197,6 @@ fn whoami_prints_identity_after_login() {
);
}

#[test]
fn whoami_updates_stale_profile_path_prefix() {
let principal_json =
PRINCIPAL_JSON.replace("\"path_prefix\":\"acme\"", "\"path_prefix\":\"fresh\"");
let stub = Stub::start(move |_m, path| match path {
"/v1/me" => (200, principal_json.clone()),
_ => (404, NOT_FOUND_JSON.to_string()),
});
let home = TempDir::new().unwrap();

auth_cmd(&home)
.args(["auth", "login", "--url", &stub.url(), "--api-key-stdin"])
.write_stdin("k_test\n")
.assert()
.success();

let credentials_path = creds_path(&home);
let raw = std::fs::read_to_string(&credentials_path).unwrap();
assert!(
raw.contains("path_prefix = \"fresh\""),
"login must cache the server-returned path prefix"
);
std::fs::write(
&credentials_path,
raw.replace("path_prefix = \"fresh\"", "path_prefix = \"stale\""),
)
.unwrap();

auth_cmd(&home)
.args(["auth", "whoami"])
.assert()
.success()
.stdout(predicate::str::contains("Path prefix: fresh"));

let updated = std::fs::read_to_string(credentials_path).unwrap();
assert!(
updated.contains("path_prefix = \"fresh\""),
"whoami must refresh the cached path prefix from /v1/me"
);
assert!(
!updated.contains("path_prefix = \"stale\""),
"stale path prefix should not remain in the saved profile"
);
}

#[test]
fn whoami_not_logged_in_with_no_credentials() {
let home = TempDir::new().unwrap();
Expand Down
Loading