-
Notifications
You must be signed in to change notification settings - Fork 142
发prod测试: merge #911 into latest main #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
The head ref may contain hidden characters: "\u53D1prod\u6D4B\u8BD5"
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
31fa058
chore(infra): prepare ops service deploy builds
law-chain-hot 17abcef
chore(deploy): support ops dev-build rollout
law-chain-hot 65f1ca7
feat(deploy): skip runner swap when identical binary is already active
law-chain-hot 5b328fe
fix(deploy): fail runner install when the expected guest never extracts
law-chain-hot f3bd786
chore(deploy): adopt PR#724 runner build/update scripts (runtime payl…
law-chain-hot 230d5a1
test(deploy): parity harness comparing bash/js runner deploy scripts
law-chain-hot f550a90
feat(deploy): add build-runner-binary.mjs JS twin (bash remains autho…
law-chain-hot 39eb65f
feat(deploy): add runner-update-binary.mjs JS twin (bash remains auth…
law-chain-hot 85f3c36
perf(docker): cache yarn/go layers in service image builds
law-chain-hot 4aa0877
Merge PR #911 into prod test branch
law-chain-hot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Reject duplicate or invalid SSM-derived dotenv keys.
Using only the final path segment can silently produce duplicate keys from nested SSM paths, and malformed leaf names can generate invalid
.enventries. Fail fast before writing.env.Suggested validation
const records = params .map((param) => ({ key: String(param.Name || '').split('/').filter(Boolean).pop(), value: String(param.Value ?? ''), version: Number(param.Version || 0), })) .filter((param) => param.key) .sort((a, b) => a.key.localeCompare(b.key)) + + const invalid = records.filter((param) => !/^[A-Za-z_][A-Za-z0-9_]*$/.test(param.key)) + if (invalid.length) { + console.error(`sst-env-sync: invalid dotenv key(s): ${invalid.map((p) => p.key).join(', ')}`) + process.exit(1) + } + + const seen = new Set() + const duplicates = records.filter((param) => { + if (seen.has(param.key)) return true + seen.add(param.key) + return false + }) + if (duplicates.length) { + console.error(`sst-env-sync: duplicate dotenv key(s): ${duplicates.map((p) => p.key).join(', ')}`) + process.exit(1) + }📝 Committable suggestion
🤖 Prompt for AI Agents