-
Notifications
You must be signed in to change notification settings - Fork 146
fix(python): raise ExecError for command start failures #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
G4614
wants to merge
13
commits into
main
Choose a base branch
from
g4614/pol-99-python-exec-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
083dd4c
fix(python): raise ExecError for command start failures
G4614 dd50047
fix(python): preserve command start error type
G4614 d978143
fix: preserve exec errors through REST
G4614 c48d44d
fix(python): distinguish command start exit codes
G4614 d841f03
test(python): assert permission-denied spawn detail
G4614 e974414
style(python): format exec error changes
G4614 b09fa9b
test(e2e): enforce typed exec start failures
G4614 47e2141
test(python): accept guest command lookup errors
G4614 c2605ec
refactor(runner): inline exec start error mapping
G4614 04d4956
refactor(python): keep exec start error internal
G4614 9360072
fix(python): keep exec start handling in simplebox
G4614 528bb07
fix(python): type exec start failures in binding
G4614 0965543
fix(python): map exec start exit codes
G4614 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,27 @@ | ||
| use pyo3::{exceptions::PyRuntimeError, prelude::*}; | ||
| use boxlite::BoxliteError; | ||
| use pyo3::{create_exception, exceptions::PyRuntimeError, prelude::*}; | ||
|
|
||
| create_exception!(boxlite_python, ExecStartError, PyRuntimeError); | ||
|
|
||
| const EXEC_START_REASON: &str = "spawn_failed"; | ||
|
|
||
| pub(crate) fn map_err(err: impl std::fmt::Display) -> PyErr { | ||
| PyRuntimeError::new_err(err.to_string()) | ||
| } | ||
|
|
||
| pub(crate) fn map_exec_start_err(err: BoxliteError) -> PyErr { | ||
| if is_exec_start_failure(&err) { | ||
| ExecStartError::new_err(err.to_string()) | ||
| } else { | ||
| map_err(err) | ||
| } | ||
| } | ||
|
|
||
| fn is_exec_start_failure(err: &BoxliteError) -> bool { | ||
| let BoxliteError::Internal(message) = err else { | ||
| return false; | ||
| }; | ||
| message | ||
| .strip_prefix(EXEC_START_REASON) | ||
| .is_some_and(|detail| detail.starts_with(": ")) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.