Attempt static scheduling, fall back to dynamic if fatal error#5
Open
jacobmischka wants to merge 1 commit intoboyland:masterfrom
Open
Attempt static scheduling, fall back to dynamic if fatal error#5jacobmischka wants to merge 1 commit intoboyland:masterfrom
jacobmischka wants to merge 1 commit intoboyland:masterfrom
Conversation
Also fix up the scala examples Makefile a bit
boyland
reviewed
May 24, 2019
Owner
boyland
left a comment
There was a problem hiding this comment.
I like the changes to the Makefile (and .gitignore) but I have two reservations about the changes to the code:
- They use global variableles and a strange recursive structure to handle arguments.
- This way, any error in static schedule leads to dynamic scheduling. My idea was that for tree languages etc, static scheduling isn't necessary (there's nothing to schedule) and this shouldn't be an error, but rather we should use dynamic scheduler, not because of dynamic scheduling per se, but because the implementation is more complete.
Author
|
Yeah, I don't love the goofy recursive structure either, but in my limited C knowledge I believe it's the only way to swallow an abort. But okay, sounds good, I'll refactor to not swallow all fatal errors and instead handle just this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix up the scala examples Makefile a bit