Skip to content

Attempt static scheduling, fall back to dynamic if fatal error#5

Open
jacobmischka wants to merge 1 commit intoboyland:masterfrom
jacobmischka:fallback-to-dynamic
Open

Attempt static scheduling, fall back to dynamic if fatal error#5
jacobmischka wants to merge 1 commit intoboyland:masterfrom
jacobmischka:fallback-to-dynamic

Conversation

@jacobmischka
Copy link
Copy Markdown

Also fix up the scala examples Makefile a bit

Also fix up the scala examples Makefile a bit
Copy link
Copy Markdown
Owner

@boyland boyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes to the Makefile (and .gitignore) but I have two reservations about the changes to the code:

  1. They use global variableles and a strange recursive structure to handle arguments.
  2. This way, any error in static schedule leads to dynamic scheduling. My idea was that for tree languages etc, static scheduling isn't necessary (there's nothing to schedule) and this shouldn't be an error, but rather we should use dynamic scheduler, not because of dynamic scheduling per se, but because the implementation is more complete.

@jacobmischka
Copy link
Copy Markdown
Author

Yeah, I don't love the goofy recursive structure either, but in my limited C knowledge I believe it's the only way to swallow an abort.

But okay, sounds good, I'll refactor to not swallow all fatal errors and instead handle just this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants