Fix bug with incorrect handling of prefixes - #23
Merged
Conversation
--- FAIL: TestMatchAbsoluteRejectsPathWithBasePrefixOnly (0.00s)
match_test.go:293: unexpected match for path outside base directory; expected nil, got file.txt
FAIL
FAIL github.com/boyter/gocodewalker/go-gitignore 0.287s
FAIL
pr-insights
Bot
added
S/size
Owner
|
Is this similar to #22 ? Just looking at the titles it seems to be yes... but not sure here. Will look though everything to confirm myself. |
Contributor
Author
|
#22 seems to be about slash-vs-backslash differences in MatchIsDir and missing specific ignore files like .git/info/exclude. This patch is a bit different; it's focused on the Absolute method. |
Owner
|
You are right. No idea what I was thinking. Thanks for the submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit adds a regression test,
second commit has a potential fix using
filepath.Rel.