Skip to content

check produce responses for errors #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/poseidon/broker_pool.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def fetch_metadata(topics)
# @param [Hash<Integer,Hash>] brokers
# Hash of broker_id => { :host => host, :port => port }
def update_known_brokers(brokers)
@brokers.values(&:close)
@brokers.update(brokers)
nil
end
Expand Down
3 changes: 2 additions & 1 deletion lib/poseidon/connection.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ def produce(required_acks, timeout, messages_for_topics)
req = ProduceRequest.new( request_common(:produce),
required_acks,
timeout,
messages_for_topics)
messages_for_topics)
puts "KAFKADEBUG PRODUCE CORRELATION #{req.common.correlation_id} from CLIENT #{@client_id} TO #{@host} #{@port}"
send_request(req)
if required_acks != 0
read_response(ProduceResponse)
Expand Down
1 change: 1 addition & 0 deletions lib/poseidon/message_conductor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def destination(topic, key = nil)
if topic_metadata && topic_metadata.leader_available?
partition_id = determine_partition(topic_metadata, key)
broker_id = topic_metadata.partitions[partition_id].leader || NO_BROKER
puts "KAFKADEBUG LEADER FOR #{partition_id} is #{broker_id}"
else
partition_id = NO_PARTITION
broker_id = NO_BROKER
Expand Down
28 changes: 26 additions & 2 deletions lib/poseidon/sync_producer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ def send_messages(messages)
end

messages_to_send.messages_for_brokers(@message_conductor).each do |messages_for_broker|
if send_to_broker(messages_for_broker)
puts "KAFKADEBUG #{@client_id} sending messages for broker #{messages_for_broker.broker_id}"

if sent_ok(send_to_broker(messages_for_broker))
messages_to_send.successfully_sent(messages_for_broker)
end
end
Expand Down Expand Up @@ -109,11 +111,33 @@ def refresh_metadata(topics)
def send_to_broker(messages_for_broker)
return false if messages_for_broker.broker_id == -1
to_send = messages_for_broker.build_protocol_objects(@compression_config)
@broker_pool.execute_api_call(messages_for_broker.broker_id, :produce,
@broker_pool.execute_api_call(messages_for_broker.broker_id, :produce,
required_acks, ack_timeout_ms,
to_send)
rescue Connection::ConnectionFailedError
false
end

def sent_ok(produce_response)
if !produce_response
false
elsif @required_acks == 0
true
else
has_errors = produce_response.topic_response.reduce(false){ |errors, response|
errors || response.partitions.reduce(false){ |part_errors, part_response|
part_errors || has_error(response, part_response)
}
}
! has_errors
end
end

def has_error(response, part_response)
if part_response.error == 6
refresh_metadata(response.topic)
end
part_response.error != 0
end
end
end