Skip to content

feature/rails4 compatibility#52

Open
dgertych-monterail wants to merge 5 commits into
bradphelan:masterfrom
dgertych-monterail:feature/rails4-compatibility
Open

feature/rails4 compatibility#52
dgertych-monterail wants to merge 5 commits into
bradphelan:masterfrom
dgertych-monterail:feature/rails4-compatibility

Conversation

@dgertych-monterail
Copy link
Copy Markdown

Hi,

rocket_tag doesn't work with rails 4

I tired to solve squeel dependancy, change scope to lambda
you should add also gem 'protected_attributes'

This solution is a hack to get rocket_tag to works, but it's incompatible with previous Rails version.

@fntz
Copy link
Copy Markdown
Contributor

fntz commented Aug 31, 2013

great.
Also change in Gemfile line source "http://rubygems.org" on source 'https://rubygems.org'

@krisleech
Copy link
Copy Markdown

@chytreg Are you thinking of submitting a PR for Rails 4 compatibility?

@krisleech
Copy link
Copy Markdown

Hold on, this is a PR, sorry...

@dgertych-monterail
Copy link
Copy Markdown
Author

:)

@bricolage
Copy link
Copy Markdown

+1. @bradphelan any chance you could accept this pull request? Thanks!

@krisleech
Copy link
Copy Markdown

ping. I wonder if this PR is backwards compatible with Rails 3. I think that the specs need running against both ActiveRecord 3 and 4. Ideally Travis would tell us this, I'd be happy to submit a seperate PR for Travis support, running the specs for both ActiveRecord 3 + 4.

@elfassy
Copy link
Copy Markdown

elfassy commented Feb 11, 2014

How about having a rails 3 branch and keep rails 4 in master?

@rilian
Copy link
Copy Markdown

rilian commented Jun 21, 2014

bump :)

@rilian
Copy link
Copy Markdown

rilian commented Jun 21, 2014

@chytreg do you have a version for rails4.1 ? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants